1169938 - Fix the worst of the pylint warnings

Status: RESOLVED WONTFIX

(Tree Management :: Treeherder, defect, P3)

Description

[Ed Morley [:emorley]]

If we're going to have landscape.io run on every commit, we might as well use it (or if we find it to not be useful let's switch it off; but let's give it a chance first).

I think much of the advantage of the score based approach of landscape.io - is that we don't have to fix all the warnings - since in theory (there are a few landscape.io bugs - have reported upstream) we can just look at the score to see if a given landing made things worse - even if we weren't at 100% before.

That said, it would be good to drive down some of the existing warnings to make it easier to see new ones as they are introduced. We should also pick some more sensible defaults for file ignore lists, pylint warning type ignore lists etc.