117023 - Javascript strict warnings in SignonViewer.js

Status: VERIFIED FIXED

(Toolkit :: Form Manager, defect)

Description

[Matthew Cline]

CVS debug build pulled at 5:50 PM December 26, PST.

When bring up the "View Stored Passwords" dialog, the following Javascript
strict warnings are generated:

WARNING: waaah!, file nsXULPrototypeDocument.cpp, line 661
JavaScript strict warning: 
chrome://communicator/content/wallet/SignonViewer.js line 146: trailing comma is
not legal in ECMA-262 object initializers

WARNING: waaah!, file nsXULPrototypeDocument.cpp, line 661
JavaScript strict warning: 
chrome://communicator/content/wallet/SignonViewer.js line 262: trailing comma is
not legal in ECMA-262 object initializers


The first error is for the initializer of variable
signonsOutlinerView, and the second is for the initializer of varible
rejectsOutlinerView.

Comment 1

[Stephen P. Morse]

Attachment: fix js errors

Comment 2

[Stephen P. Morse]

cc'ing alecf and sgehani for reviews

Comment 3

[Zibi Braniecki [:zbraniecki][:gandalf]]

And I got:
Error: document.getElementById("removeAllRejects") has no properties
Source File: chrome://communicator/content/wallet/SignonViewer.js
Line: 286

at the same moment.

Comment 4

[Stephen P. Morse]

Comment #3 is not related to this bug report.  If there is a problem, then 
please report it in a separate report.

This report covers the js errors due to trailing comma at the end of a list.  It 
indeed occurs in the two places reported in this report, as well as two other 
places in signonviewer.js and also in two places in cookieviewer.js.  Those are 
all fixed by the attached patch.

I don't mean to be picuyune in requiring a separate report for comment #3, but 
there are good reasons for doing so.  First off, the comment might be invalid in 
which case it would confuse things as to how to close out this report (invalid?, 
fixed?).  Second, it's not at all obvious why that error should be occuring if 
it indeed occurs, so I don't have a quick fix for it and I don't want to have 
that block checking in the obvious fixes for the problems that are covered by 
this report.

Comment 5

[Samir Gehani]

Comment on attachment 62810 [details] [diff] [review]
fix js errors

r=sgehani

Comment 6

[Alec Flett]

Comment on attachment 62810 [details] [diff] [review]
fix js errors

sr=alecf

Comment 7

[Stephen P. Morse]

Patch checked in

Comment 8

[Stephen P. Morse]

Zbigniew Braniecki: I didn't forget about your comment #3 above.  I just tested 
it and opened bug 117998 on that bug.  It's more than just a js warning as 
described in the new bug report.

Comment 9

[Zibi Braniecki [:zbraniecki][:gandalf]]

Huh. Thanks :)
Next time I'll report it myself :)

Comment 10

[Henrik Gemal]

verified fixed in 20020115