1170691 - use GENERATED_FILES in toolkit/components/telemetry/

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: use GENERATED_FILES in toolkit/components/telemetry/

The patch is mostly noise from using function-style print in the scripts, but
ideally the intent should be pretty clear.

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 8614225 [details] [diff] [review]
use GENERATED_FILES in toolkit/components/telemetry/

Argh, now we can't import modules from the srcdir.  Canceling review for the moment.

Comment 3

[Nathan Froyd [:froydnj]]

Attachment: part 1 - add the generating script's directory to sys.path in file_generate.py

The old way of writing scripts for generated files would invoke the script thusly:

    python script.py arg1...

Invoking the script this way means that the script's directory is
automatically added to sys.path, and importing modules from that
directory is easy.  Let's make it equally easy in the new world for
GENERATED_FILES, too.

Comment 4

[Nathan Froyd [:froydnj]]

Comment on attachment 8614225 [details] [diff] [review]
use GENERATED_FILES in toolkit/components/telemetry/

mshal isn't doing reviews at this point, so picking on glandium.

Comment 5

[Nathan Froyd [:froydnj]]

Comment on attachment 8614262 [details] [diff] [review]
part 1 - add the generating script's directory to sys.path in file_generate.py

mshal isn't doing reviews at this point, so picking on glandium.

Comment 6

[Mike Hommey [:glandium]]

Comment on attachment 8614225 [details] [diff] [review]
use GENERATED_FILES in toolkit/components/telemetry/

Review of attachment 8614225 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/telemetry/moz.build
@@ +57,5 @@
>  ]
>  
> +histogram_files = [
> +    SRCDIR + '/Histograms.json',
> +    TOPSRCDIR + '/dom/base/UseCounters.conf',

Rebase on top of bug 1170431

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b1aec9026884
https://hg.mozilla.org/integration/mozilla-inbound/rev/282f50513dd4

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b1aec9026884
https://hg.mozilla.org/mozilla-central/rev/282f50513dd4