1170707 - connectivity issue during sync sign-in leads to confusing UI state, possible UI hang?

Status: RESOLVED FIXED

(Firefox for iOS :: Firefox Accounts, defect)

Description

[:Gavin Sharp [email: [e-mail]]]

Attachment: post sign-in screenshot

I just tried signing in to TestFlight build 19 for the first time. I think what happened is:

1) Entered my username/password (took a while since I had to go look up my password in 1password)
2) The Mountain View wireless is kind of spotty, and as I submitted the sign-in form my internet connection dropped (I was flipping between wifi and LTE)

After this, I got a preferences UI that said "Enter your password to connect" (see screenshot), which was confusing (since I had just done that). I tried tapping that row to see what that was about, but that apparently did nothing. I was only able to dismiss the settings window by hitting the "Done" button, after which I ended up on the tabs screen, and the whole app froze up (no buttons were responsive at all). I assume this could have been caused by the syncing?

It eventually recovered and my sync data appeared without any additional action, and going back to the settings pane showed the normal UI.

Comment 3

[Chris Karlof [:ckarlof]]

It's probably obvious, but we need to investigate whether this issue is being caused by anything in our Web content for FxA.

Comment 4

[Aaron Train [:aaronmt]]

Still visible on Build #24. This is terrible UX.

Comment 5

[Nick Alexander :nalexander [he/him]]

(In reply to Aaron Train [:aaronmt] from comment #4)
> Still visible on Build #24. This is terrible UX.

I will try to get to this before I go on PTO this Friday but I'm "a little busy".

Comment 6

[Aaron Train [:aaronmt]]

Any update here?

Comment 7

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

I don't think this has anything to do with connectivity issues. It always happens, on both device and in simulator. Looks more like a state / ui out-of-sync issue.

Comment 8

[Nick Alexander :nalexander [he/him]]

(In reply to Stefan Arentz [:st3fan] from comment #7)
> I don't think this has anything to do with connectivity issues. It always
> happens, on both device and in simulator. Looks more like a state / ui
> out-of-sync issue.

Stefan is correct.  I dug into this and have a patch in the works.

What is happening is that we've grown consumers of FirefoxAccount.advance(), and they're now racing at setup time.  Different parts of the UI start advancing the account.  One of the setup tokens from the fxa-content-server is single use; all advancers that try to reuse it fail.  By the time the successful advancer finishes, parts of the UI have already seen an error (even though the final advance is successful).

rnewman and I discussed how to lock this efficiently; patch inbound.

Comment 9

[Nick Alexander :nalexander [he/him]]

Attachment: Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/861

Comment 11

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8643203 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/861

st3fan is under water post-PTO, so redirecting to etoop, who has worked in this area.

Comment 12

[Nick Alexander :nalexander [he/him]]

Landed with r=etoop,st3fan f=rnewman.

https://github.com/mozilla/firefox-ios/commit/adb0927ed01ed13bad09cae3284eb631d33af281

AaronMT: this could use verification.  It should be as simple as not observing a "PW required" orange error when signing in to an existing Firefox Account.

Comment 13

[Nick Alexander :nalexander [he/him]]

AaronMT: further, any janky syncing or hanging pull-to-refresh, etc, that you observe should start by pointing the finger at this ticket.

Comment 14

[Aaron Train [:aaronmt]]

(In reply to Nick Alexander :nalexander from comment #12)
> Landed with r=etoop,st3fan f=rnewman.
> 
> https://github.com/mozilla/firefox-ios/commit/
> adb0927ed01ed13bad09cae3284eb631d33af281
> 
> AaronMT: this could use verification.  It should be as simple as not
> observing a "PW required" orange error when signing in to an existing
> Firefox Account.

Aye, looks good

(In reply to Nick Alexander :nalexander from comment #13)
> AaronMT: further, any janky syncing or hanging pull-to-refresh, etc, that
> you observe should start by pointing the finger at this ticket.

There's https://bugzilla.mozilla.org/show_bug.cgi?id=1191925