1171029 - gfx/layers/apz/test/test_wheel_scroll.html fails when using GDK_SCROLL_SMOOTH

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Andrew Comminos [:acomminos]]

Our workaround for omitting duplicate GDK_SCROLL_SMOOTH events causes synthesized scroll events to be skipped when GDK_SCROLL_SMOOTH is used for scroll synthesis, making gfx/layers/apz/test/test_wheel_scroll.html fail on the tryserver. This is because synthesized events are all initialized to GDK_CURRENT_TIME.

> #if GTK_CHECK_VERSION(3,4,0)
>     // check for duplicate legacy scroll event, see GNOME bug 726878
>     if (mLastScrollEventTime == aEvent->time)
>         return;                
> #endif

Comment 1

[Andrew Comminos [:acomminos]]

Attachment: Only omit legacy scroll events on GTK3.

This patch modifies our detection of duplicate scroll events as documented in bug 958868 to only omit legacy events.

Thanks!

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/86e252f5ad3e

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/86e252f5ad3e