1171315 - View source in tab formatting options aren't very discoverable

Status: NEW

(Toolkit :: View Source, defect)

Description

[Boris Zbarsky [:bzbarsky]]

[Tracking Requested - why for this release]: Serious view-source usability regression

A normal view-source window has separate options for toggling wrapping of long lines and syntax highlighting.  view-source in a tab seems to have lost those options.

Maybe this is some of the stuff Paul though was unimportant in bug 1067325 comment 1?  I assure you, it's important for me....

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

These formatting options are accessible via the context menu in a view source tab.  Does that work for your use case?

Comment 2

[Boris Zbarsky [:bzbarsky]]

Hmm.  I can make that work, I guess.  Not terribly discoverable, but now that I know it's there...

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to Not doing reviews right now from comment #2)
> Hmm.  I can make that work, I guess.  Not terribly discoverable, but now
> that I know it's there...

Right, I agree it's not as easy to find as it is in window mode.

I'll morph this into making them easier to find.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

We should add a horizontal toolbar at the top of the View Source page that includes the options found in the context menu.

This can also be used to get rid of the "Go to line" modal dialog by replacing that with a textbox in the toolbar "Go to line: [       ]"

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Really hacky proof-of-concept

This patch would likely need to be rewritten so that we can reuse contextMenuItems so it would work for the toolbar as well as the context menu.

I don't have time to work on this bug, but maybe someone else wants to look at what I have and put together a better patch.