Closed
Bug 1171949
Opened 9 years ago
Closed 9 years ago
Play a sound when a chat message is received
Categories
(Hello (Loop) :: Client, defect, P1)
Hello (Loop)
Client
Tracking
(firefox41 verified)
Tracking | Status | |
---|---|---|
firefox41 | --- | verified |
People
(Reporter: mikedeboer, Assigned: standard8)
References
Details
(Whiteboard: [chat])
User Story
As a Hello user in an IM session (desktop client or standalone UI user), I want to be notified that I received an IM with a sound so that I don't miss it. Acceptance criteria: - Sound 1 for the first message received in a conversation (prominent) - Sound 2 for new messages received in an existing conversation when the window is not in front/focus - Sound 3 for new message received with the window in front/focus (extremely subtle)
Attachments
(2 files)
357.50 KB,
application/zip
|
Details | |
36.89 KB,
patch
|
standard8
:
review+
|
Details | Diff | Splinter Review |
1) We'll need a sound file (.ogg format) for the incoming message notification. 2) Implement playing that sound once a message is received from the remote party. Romain, can you provide us with this sound file or should we re-use an existing one?
Flags: qe-verify+
Flags: needinfo?(rtestard)
Flags: firefox-backlog+
Comment 1•9 years ago
|
||
FYI I'm looking into getting the following sounds with a consultant per discussions with Abr and Sevaan: 1 First message received in a conversation (prominent) 2 New message received in an existing conversation when the window is not in front/focus 3 New message received with the window in front/focus (extremely subtle) 4 Review of the current sounds (someone joined/connected/disconnected) and at least make the "someone joined" sound more noticeable The target is to provide the sounds before the end of the Aurora 41 cycle.
User Story: (updated)
Updated•9 years ago
|
Rank: 23
Priority: P1 → P2
Whiteboard: [chat]
Comment 2•9 years ago
|
||
Discussed whith Sevaan who said he may be able to help, Sevaan I NI yuo so you can provide an update when you know more.
Flags: needinfo?(rtestard) → needinfo?(sfranks)
Comment 3•9 years ago
|
||
My brother Sebastian has provided a couple options. We can make adjustments as needed. Do any of these sounds resonate with people?
Flags: needinfo?(sfranks)
Reporter | ||
Updated•9 years ago
|
Flags: needinfo?(standard8)
Flags: needinfo?(rtestard)
Flags: needinfo?(adam)
Reporter | ||
Comment 4•9 years ago
|
||
Sevaan, RT talks about three distinct sounds in comment 1... Which sound does Sebastian think fits with which scenario?
Flags: needinfo?(sfranks)
Comment 5•9 years ago
|
||
What do you guys think of just using 'Chat Sound.wav' and having it play at two different volumes? A louder one for when you are off the tab (including the first chat message), and then a more subtle one for when you are on the tab, so it's not as annoying?
Flags: needinfo?(sfranks)
Updated•9 years ago
|
Assignee: nobody → dmose
Comment 6•9 years ago
|
||
(In reply to Sevaan Franks [:sevaan] from comment #5) > What do you guys think of just using 'Chat Sound.wav' and having it play at > two different volumes? A louder one for when you are off the tab (including > the first chat message), and then a more subtle one for when you are on the > tab, so it's not as annoying? That sounds good to me.
Flags: needinfo?(rtestard)
Assignee | ||
Updated•9 years ago
|
Rank: 23 → 13
Flags: needinfo?(standard8)
Priority: P2 → P1
Comment 7•9 years ago
|
||
I'm still interested in working on this bug, but I'm unlikely to get time until at least Monday, so letting go of it for now in case someone feels like picking it up in the interim.
Assignee: dmose → nobody
Comment 8•9 years ago
|
||
(In reply to Sevaan Franks [:sevaan] from comment #5) > What do you guys think of just using 'Chat Sound.wav' and having it play at > two different volumes? A louder one for when you are off the tab (including > the first chat message), and then a more subtle one for when you are on the > tab, so it's not as annoying? I like the sound, but I think that we need something that is not just quieter, but actually less distracting (less complex) and shorter in duration for the messages that arrive in a focused window. In fact, I think it would be okay to omit the audio alert for these messages. I do think that something louder and -- just as importantly -- longer in duration for an initial message in a session would be far better than having the same noise for all messages in an unfocused window, but I don't feel strongly enough about it to stand in the way.
Flags: needinfo?(adam)
Assignee | ||
Comment 9•9 years ago
|
||
This implements a basic sound for when text messages are received. This has been pair reviewed by dmose in person.
Attachment #8625865 -
Flags: review+
Comment 11•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/edda2b44b087
Assignee: nobody → standard8
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Updated•9 years ago
|
Iteration: --- → 41.3 - Jun 29
Comment 12•9 years ago
|
||
I did some exploratory testing across platforms (Windows 7 64-bit, Mac OS X 10.10.4 and Ubuntu 14.04 32-bit) using latest Aurora 41.0a2 and can confirm the sound can be heard without any problem when receiving a message.
You need to log in
before you can comment on or make changes to this bug.
Description
•