1172019 - make strings on thank you page product-agnostic

Status: RESOLVED FIXED

(Input Graveyard :: Submission, defect, P1)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

All the strings on the Thank You page that refer to a product have "Firefox" hard-coded.

This bug covers:

1. fixing the thank you page view to include the product in the context
2. creating new strings that are product-agnostic
3. make sure the new strings get translated
4. swap the old strings for the new strings

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

Grabbing this.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

In a PR: https://github.com/mozilla/fjord/pull/598

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

Landed in master: https://github.com/mozilla/fjord/commit/64937b512ac4c0768de5d3549e940c5d7c9de28d

Next step is to sync strings with verbatim and then wait for them to get translated.

Once they're translated we can move the strings around and ditch the old ones. Probably worth checking in 3 weeks.

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

I checked the localizations on postatus (https://postatus.herokuapp.com/p/Input/l10n_summary?app=feedback&highlight=es,pt_BR,po,hu,de,gr,fr,it,ru,ja,tr,zh_TW,zh_CN,el) and everything looks ok. However, I went to test fr and the strings aren't translated, yet.

I suspect there's a bug with the postatus checker or the script that's verifying things. Will look into that today.

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

I fixed the l10n_completion script to count fuzzy strings as untranslated. That should make things show up correctly in the postatus app.

I'll have to wait some more on this one.

Comment 6

[Will Kahn-Greene [:willkg] ET needinfo? me]

Still waiting on es, fr, el and hu. If they're not done by next week, I'll write up bugs for them.

Comment 7

[Will Kahn-Greene [:willkg] ET needinfo? me]

I wrote up bugs for the languages that still need translations. Making this bug block on them.

Comment 8

[Will Kahn-Greene [:willkg] ET needinfo? me]

el still hasn't finished translating, but all the other locales have so I'm going to push this out now.

In a PR: https://github.com/mozilla/fjord/pull/624

Comment 9

[Will Kahn-Greene [:willkg] ET needinfo? me]

Landed in master in https://github.com/mozilla/fjord/commit/22ebac23de9ee99b42dce60a108c57b3e1de23e9

I'll push this out later today.

Comment 10

[Will Kahn-Greene [:willkg] ET needinfo? me]

This took about 2 points of work all told.

Comment 11

[Will Kahn-Greene [:willkg] ET needinfo? me]

Pushed this to production just now. Marking as FIXED.