Closed
Bug 1172195
Opened 9 years ago
Closed 9 years ago
Unlocalized string on mozilla.org/firefox/desktop
Categories
(www.mozilla.org :: L10N, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: theo, Assigned: flod)
Details
We have an unlocalized string on https://www.mozilla.org/firefox/desktop/ "That’s why we’re proud to be voted the Most Trusted Internet Company for Privacy." Introduced by https://github.com/mozilla/bedrock/commit/0f6ac108394efa9b492eb847f61fdb93fa0c3166#diff-ba76492eda61d9819f980db9f56dc7b4R68 ~10 days ago.
Reporter | ||
Comment 2•9 years ago
|
||
D'oh, just noticed there are two unlocalized strings: * Based on Tom’s Hardware Web Browser Grand Prix XVI results.
Reporter | ||
Comment 3•9 years ago
|
||
Ok, there are actually moref strings. I did a quick review of the patch, here's a recap of what I found: In desktop/index.lang: That’s why we’re proud to be voted the <a href="{{ url1 }}" data-interaction="outbound link">Most Trusted Internet Company for Privacy.</a> * Based on <a data-interaction="outbound link" href="{{ url1 }}">Tom’s Hardware Web Browser Grand Prix XVI</a> results. In sync.lang Open the <a class="menu ga-link" data-interaction="outbound link click" href="{{ url }}#w_a-handy-new-menu">menu</a> in the top right of Firefox and select “<strong>Sign in to Sync.</strong>” In fast.lang: Firefox outperformed other browsers in recent independent tests to be named <br class="wide-br">the <a href="{{ url1 }}" data-interaction="outbound link">“speed king.”</a> That should be it.
Assignee | ||
Comment 4•9 years ago
|
||
Wow, that patch broke the world :-\ I'll go through the patch to double check your list and fix localizations.
Assignee: nobody → francesco.lodolo
Assignee | ||
Comment 5•9 years ago
|
||
Some fixes in r142164 rr142165 r142166 Still need to go through the patch to double check.
Comment 6•9 years ago
|
||
On webdashboard these "missing" strings are displayed without the data-interaction attribute. Shall this attribute used or shall it not?
Assignee | ||
Comment 7•9 years ago
|
||
(In reply to Michael Wolf from comment #6) > On webdashboard these "missing" strings are displayed without the > data-interaction attribute. Shall this attribute used or shall it not? It was a temporary thing, it should be already fixed.
Comment 8•9 years ago
|
||
OK, thank you, meanwhile I read the message of Michael Köhler and your reply to this.
Assignee | ||
Comment 9•9 years ago
|
||
Checked the patch and couldn't find any other string. Thanks for the list Théo, that helped a lot.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•