Closed
Bug 1172243
Opened 9 years ago
Closed 9 years ago
Don't duplicate the newsblog directory in TB
Categories
(Thunderbird :: Theme, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 41.0
People
(Reporter: Paenglab, Assigned: Paenglab)
Details
Attachments
(1 file, 2 obsolete files)
13.59 KB,
patch
|
Paenglab
:
review+
|
Details | Diff | Splinter Review |
Like bug 1172242 use only one newsblog directory. After this two bugs we have only the messenger directory in aero branch.
Assignee | ||
Comment 1•9 years ago
|
||
This patch needs to be applies after bug 1172242. Like FX I'm renaming the XP image to -XP and remove the -aero from aero image.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8616377 -
Flags: review?(bwinton)
Assignee | ||
Comment 2•9 years ago
|
||
Updated after landing of bug 1150627
Attachment #8616377 -
Attachment is obsolete: true
Attachment #8616377 -
Flags: review?(bwinton)
Attachment #8620517 -
Flags: review?(bwinton)
Comment 3•9 years ago
|
||
Comment on attachment 8620517 [details] [diff] [review] deDupNewsblog.patch Review of attachment 8620517 [details] [diff] [review]: ----------------------------------------------------------------- Other than the nit below, r=me! Thanks! :) ::: mail/themes/windows/jar.mn @@ +274,5 @@ > skin/classic/messenger/icons/arrow/foldercycler-arrow-right.png (mail/icons/arrow/foldercycler-arrow-right.png) > skin/classic/messenger/icons/xp-pin-grey.png (mail/icons/xp-pin-grey.png) > skin/classic/messenger/icons/xp-pin-red.png (mail/icons/xp-pin-red.png) > skin/classic/messenger/tagbg.png (mail/tagbg.png) > +% skin messenger-newsblog classic/1.0 %skin/classic/messenger-newsblog/ os=WINNT Like a previous patch, this seems to be removing the mapping for os!=WINNT, which I don't think we want. Can it just be % skin messenger-newsblog classic/1.0 %skin/classic/messenger-newsblog/ instead?
Attachment #8620517 -
Flags: review?(bwinton) → review+
Assignee | ||
Comment 4•9 years ago
|
||
Fixed the review comment. Carrying over the r+ from previous patch.
Attachment #8620517 -
Attachment is obsolete: true
Attachment #8624313 -
Flags: review+
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Updated•9 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 41.0
You need to log in
before you can comment on or make changes to this bug.
Description
•