11726 - ReplaceDotMess errors when backslashes are in an URL.

Status: VERIFIED FIXED

(Core :: Networking, defect, P3)

Description

[Daniel Bratell]

Overview Description:

If slash and backslash should be treated the same in a path as suggested by the
fix to bug 8573, then there are a few trivial errors in functionality in
|nsStdUrl|s ReplaceDotMess function where the lookahead doesn't take backslashes
into account. Because it's a look ahead the backslashes are still there since
they're not converted yet.


Patch to fix (against nsStdURL.cpp v1.11):

Index: nsStdURL.cpp
===================================================================
RCS file: /cvsroot/mozilla/netwerk/base/src/nsStdURL.cpp,v
retrieving revision 1.11
diff -u -r1.11 nsStdURL.cpp
--- nsStdURL.cpp        1999/08/12 09:59:24     1.11
+++ nsStdURL.cpp        1999/08/12 12:17:47
@@ -933,15 +933,19 @@

     for(; *fwdPtr != '\0'; ++fwdPtr)
     {
+        // Replace \ with /
                if (*fwdPtr == '\\')
                        *fwdPtr = '/';
-        if (*fwdPtr == '/' && *(fwdPtr+1) == '.' && *(fwdPtr+2) == '/')
+
+        if (*fwdPtr == '/' && *(fwdPtr+1) == '.' &&
+            (*(fwdPtr+2) == '/' || *(fwdPtr+2) == '\\'))
         {
-            // remove ./
+            // remove /. if followed by a slash or backslash
             fwdPtr += 1;
         }
         else if(*fwdPtr == '/' && *(fwdPtr+1) == '.' && *(fwdPtr+2) == '.' &&
-                (*(fwdPtr+3) == '/' || *(fwdPtr+3) == '\0'))
+                (*(fwdPtr+3) == '/' || *(fwdPtr+3) == '\\' ||
+                 *(fwdPtr+3) == '\0'))
         {
             // remove foo/..
             // reverse the urlPtr to the previous slash

Comment 1

[Daniel Bratell]

The above patch attached.

Comment 2

[Daniel Bratell]

Attachment: Patch as in first comment.

Comment 3

[Gagan]

You are right! I must be sleepy to have missed that... I will apply the patch
and check it in soon. Thanks!

Comment 4

[Paul MacQuiddy]

brattel, can you verify that your patch was applied? thanks

Comment 5

[Daniel Bratell]

It's applied ok.

Comment 6

[leger]

Bulk move of all Networking-Core (to be deleted component) bugs to new
Networking component.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0b9fd3f6d51b
[components] Closes https://github.com/mozilla-mobile/android-components/issues/11726: Fix intermittents in recently closed tabs storage tests