Closed
Bug 1173097
Opened 9 years ago
Closed 9 years ago
[Contacts][NGA] Extract 'goToSelectTag' functionality to it own .js class
Categories
(Firefox OS Graveyard :: Gaia::Contacts, defect)
Tracking
(b2g-master fixed)
RESOLVED
FIXED
FxOS-S1 (26Jun)
Tracking | Status | |
---|---|---|
b2g-master | --- | fixed |
People
(Reporter: borjasalguero, Assigned: jorgep)
References
Details
(Whiteboard: [NG Gaia Contacts])
Attachments
(1 file)
We need to extract from contact.js the functionality not related with contacts, in order to have a reusable and modular code. In this bug we will generate a 'TagSelector' object, which will expose a 'show' and 'hide' for being used in 'forms.js'.
Updated•9 years ago
|
Whiteboard: [NG Gaia Contacts]
Updated•9 years ago
|
Target Milestone: --- → NGA S2 (12Jun)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → jpruden92
Assignee | ||
Updated•9 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8617864 -
Flags: feedback?(borja.bugzilla)
Reporter | ||
Comment 2•9 years ago
|
||
Comment on attachment 8617864 [details]
30515.html
Some comments to address! Let me know when the patch will be ready and I'll take a look again. Great job!
Attachment #8617864 -
Flags: feedback?(borja.bugzilla)
Assignee | ||
Updated•9 years ago
|
Attachment #8617864 -
Flags: review?(francisco)
Attachment #8617864 -
Flags: review?(borja.bugzilla)
Updated•9 years ago
|
Target Milestone: NGA S2 (12Jun) → NGA S3 (26Jun)
Reporter | ||
Comment 3•9 years ago
|
||
Comment on attachment 8617864 [details]
30515.html
Great job! Ensure all tests are in green before merging. Thanks!
Attachment #8617864 -
Flags: review?(borja.bugzilla) → review+
Comment 4•9 years ago
|
||
Comment on attachment 8617864 [details]
30515.html
LGTM, left a comment on github about when we should load the new script.
Giving the r+ but please fix that first.
Thanks!
Attachment #8617864 -
Flags: review?(francisco) → review+
Reporter | ||
Updated•9 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Updated•9 years ago
|
status-b2g-master:
--- → fixed
Comment 5•9 years ago
|
||
As NGA Program Manager suggested, let's replace the NGA-X milestones with FxOS-Sx ones (more generic ones), once Bug 1174794 has already landed
Target Milestone: NGA S3 (26Jun) → FxOS-S1 (26Jun)
You need to log in
before you can comment on or make changes to this bug.
Description
•