1173337 - Fix and re-enable test_privbrowsing_perwindowpb.html

Status: RESOLVED FIXED

(Toolkit :: Password Manager, defect, P1)

Description

[Ryan VanderMeulen [:RyanVM]]

test_privbrowsing_perwindowpb.html was originally disabled in bug 919016. However, that test became a dumping ground for different issues. Per a recent Try push, this test is still severely broken across all platforms.

Opt builds continue to hit the failure mode described in bug 919016:
https://treeherder.mozilla.org/logviewer.html#?job_id=8353124&repo=try

2616 INFO TEST-UNEXPECTED-FAIL | toolkit/components/passwordmgr/test/test_privbrowsing_perwindowpb.html | Checking submitted password - got , expected notifyp1

Debug builds are also susceptible to the failures above. Additionally, they also frequently hit asserts and crashes:
https://treeherder.mozilla.org/logviewer.html#?job_id=8353022&repo=try

Assertion failure: mSearchesOngoing > 0 && mSearches.Contains(aSearch), at /builds/slave/try-lx-d-000000000000000000000/build/src/toolkit/components/autocomplete/nsAutoCompleteController.cpp:771
PROCESS-CRASH | toolkit/components/passwordmgr/test/test_privbrowsing_perwindowpb.html | application crashed [@ nsAutoCompleteController::OnSearchResult(nsIAutoCompleteSearch*, nsIAutoCompleteResult*)]

Comment 1

[Dão Gottwald [:dao]]

Bug 1462281 removes the getNotificationBox function form browser.js that is used in this test.

Comment 2

[Matthew N. [:MattN]]

We need this test coverage and having chrome.ini with no enabled tests breaks mach test on the parent directory. This should be ported to m-bc.

Comment 3

[Sam Foster [:sfoster] (he/him)]

Attachment: Bug 1173337 - Port private browsing tests to browser-chrome. r?MattN

• Added browser_privbrowsing_notifications.js - which is a port of chrome/privbrowsing_perwindowpb.html
• Moved onload/form submit from the form documents to the test via ContentTask.spawn
  from the form documents to the test via ContentTask.spawn

TODO/WIP:

• The sub-test 7 is supposed to aufill the form and trigger the asswordmgr-processed-form observers. I'm still trying to figure out why this isn't happening.
• The sub-tests 8-10 aren't ported yet.
• I've not removed the chrome/ directory yet.

Comment 4

[Sam Foster [:sfoster] (he/him)]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3701394bfca74cc4337f2c87cfdfa796e5d2a743&selectedJob=224832949

..not sure why the windows builds didn't work out, but otherwise looks good I think?

Comment 5

[Matthew N. [:MattN]]

(In reply to Sam Foster [:sfoster] from comment #4)

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3701394bfca74cc4337f2c87cfdfa796e5d2a743&selectedJob=224832949

..not sure why the windows builds didn't work out, but otherwise looks good I think?

I had the same Windows build issue on Try today so I think you can ignore it.

Comment 6

[Matthew N. [:MattN]]

Btw. you should schedule test-verify-e10s in the future

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/25a343e42273
Port private browsing tests to browser-chrome. r=MattN

Comment 8

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/25a343e42273