1173519 - Mention event channels in new video emails

Status: RESOLVED FIXED

(Webtools Graveyard :: Air Mozilla, defect)

Description

[Peter Bengtsson [:peterbe]]

Attachment: Screenshot 2015-06-10 13.24.28.png

There's no mention of which channel your recently uploaded video landed in.

Comment 1

[anjaly]

Hey!
I would like to take up this bug if its fine?

Comment 2

[Peter Bengtsson [:peterbe]]

(In reply to anjaly from comment #1)
> Hey!
> I would like to take up this bug if its fine?

Go for it! I suggest you study the README on github and then make a GitHub Pull Request. If it goes into review for inclusion, we'll assign this bug to you.

Comment 3

[anjaly]

Hey 

I couldn't identify the flow as in what are the step that need to be followed which leads to email to be sent. I tried uploading videos (once submitted ,an email is sent out?) but it failed.

Comment 4

[Peter Bengtsson [:peterbe]]

I'm sorry the README is so long. It gets boring to read :)

See the section about how you have to set up::

    EMAIL_BACKEND = 'django.core.mail.backends.console.EmailBackend'

That'll make sure emails are sent to the console rather than being sent over SMTP.

Comment 5

[anjaly]

Attachment: error_screenshot.JPG

Yes i did change the settings. But the problem here is the error while uploading a video :\

Comment 6

[Peter Bengtsson [:peterbe]]

To be able to upload a video you need an AWS S3 account. Do you have that?

Comment 7

[anjaly]

No I don't. I have made some changes to include channels in the email , so I thought uploading and testing if it works well was right thing to do. 
Is there any workaround for test?

Comment 8

[Peter Bengtsson [:peterbe]]

(In reply to anjaly from comment #7)
> No I don't. I have made some changes to include channels in the email , so I
> thought uploading and testing if it works well was right thing to do. 
> Is there any workaround for test?

At the moment there is no way to add videos without a AWS S3 account. Sorry. And you'd need to fake the Vidly submission too.

Comment 9

[anjaly]

Hi 
Here is link to git pull request

https://github.com/mozilla/airmozilla/pull/497

Comment 10

[anjaly]

I tried writing test to see if the channel links are there in html body and ran it but it is failing saying there is no such pattern . Here is the link :-https://gist.github.com/anjalymehla/38ced32ab9d99660cb8c

Could you tell me what is wrong here?

Comment 11

[Peter Bengtsson [:peterbe]]

It needs to be `reverse('main:home_channels', args=(channel.slug,)` not `reverse('main:home_channels', args=(channel.slug)`

The difference is that ('one',) is a tuple but ('one') is just a single string in brackets. 
When you ask to iterate over a string it splits it up in one character at a time. Try this in a python shell:

>>> for each in 'astring':
>>> ....print each

>>> for each in ('astring'):
>>> ....print each

>>> for each in ('astring',):
>>> ....print each

Comment 12

[anjaly]

Hi 
I have updated the branch here :- https://github.com/mozilla/airmozilla/pull/497

Comment 13

[[github robot]]

Commits pushed to master at https://github.com/mozilla/airmozilla

https://github.com/mozilla/airmozilla/commit/78643bf377ef11ca57a75fae669d7be782ae62d6
Bug 1173519 Mention event channels in new video emails fixing

https://github.com/mozilla/airmozilla/commit/cb14701c797c559a60bae9b766022baa1fa79c7d
Merge pull request #497 from anjalymehla/1173519-Mention-event-channels-in-new-video-emails

Bug 1173519 Mention event channels in new video emails fixing

Comment 14

[Peter Bengtsson [:peterbe]]

Thanks anjaly!

Do you have a Mozillians account? The next thing you need to do is to create an account there and click to request to join this group: https://mozillians.org/en-US/group/air-mozilla-contributors/

If you do that, and if you upload a picture I'll make it so that you appear on this page: https://air.mozilla.org/contributors/

Comment 15

[anjaly]

Yes I do have but I am not yet vouched so can't make request to join groups :|

Comment 16

[Peter Bengtsson [:peterbe]]

(In reply to anjaly from comment #15)
> Yes I do have but I am not yet vouched so can't make request to join groups
> :|

What's your username on mozillias? Richard and I can vouch for you.

Comment 17

[anjaly]

Oh that would be great ! This is me here :)
https://mozillians.org/en-US/u/anjalymehla/

Comment 18

[Peter Bengtsson [:peterbe]]

Vouched for now! See comment #14 above :)