117399 - UMR of mModCount in nsEditor::IncrementModificationCount

Status: VERIFIED FIXED

(SeaMonkey :: Composer, defect)

Description

[John Morrison]

Purify reports a UMR here, in nsEditor.cpp:

    NS_IMETHODIMP nsEditor::IncrementModificationCount(PRInt32 inNumMods)
    {
      PRUint32 oldModCount = mModCount;

      mModCount += inNumMods;

      if ((oldModCount == 0 && mModCount != 0)
       || (oldModCount != 0 && mModCount == 0))
        NotifyDocumentListeners(eDocumentStateChanged);
      return NS_OK;
    }

inNumMods is 1, but mModCount is 0xdeadbeef. Just need to initialize in 
the constructor, I suppose. (Note: it doesn't report the UMR for every 
call to IncrementModificationCount, only for (I guess) the initial call).

Comment 1

[Kathleen :Brade]

strange... I must have lost the initialization when preparing my patch.

Comment 2

[Kathleen :Brade]

*** Bug 114578 has been marked as a duplicate of this bug. ***

Comment 3

[Kathleen :Brade]

Attachment: initialization in constructor

Comment 4

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Comment on attachment 63815 [details] [diff] [review]
initialization in constructor

r=glazman

Comment 5

[Kathleen :Brade]

fix checked in (sr=kin after changing order to not cause warning on Linux)

Comment 6

[[e-mail] (gone - use [e-mail] instead)]

I can verify that this is fixed, at least from my testcast in bug 114578, on 
Windows 2000 under Purify.