1174132 - Context shows the opengraph title instead of the document title, sometimes leading to shortened descriptions of urls

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[Bogdan Maris, Desktop QA]

Attachment: Screenshot showing the issue

Affected builds:
- Latest Nightly
- Latest Aurora

Affected OS`s:
- Windows 7 64-bit
- Mac OS X 10.9.5
- Ubuntu 14.04 32-bit

STR:
1. Start Firefox
2. Visit http://pocketnow.com/
3. Click hello icon

Expected results: Complete name is shown in hello panel.

Actual results: Incomplete name is shown in hello panel.

'- Smartphone, Tablet, and Wearable Reviews, Videos, Editorials and News'
instead of:
'Pocketnow | Smartphone, Tablet, and Wearable Reviews, Video, Editorial, and News'

Notes:
- Screenshot showing the isssue attached.
- Not a regression, reproducible on Nightly 2015-05-10 where context was enabled by default.

Comment 1

[Bogdan Maris, Desktop QA]

Apparently not only website titles that contain vertical bar will not be completely displayed, another example:
STR:
1. Visit: https://www.youtube.com/live
2. Click Hello icon

Only '#Live' will appear instead of '#Live - YouTube'

Comment 2

[Mark Banner (:standard8)]

I've just dug into this. Looks like its a comes from our "PageMetadata".

In the pages referenced in comment 0 and comment 1, there's two html elements in each that are relevant:

<title>Pocketnow | Smartphone, Tablet, and Wearable Reviews, Video, Editorial, and News</title>
<meta property="og:title" content="- Smartphone, Tablet, and Wearable Reviews, Videos, Editorials and News" />

and:

<title>  #Live - YouTube</title>
<meta property="og:title" content="#Live">

For some reason, probably the open graph stuff, the PageMetadata module is selecting og:title over document.title.

Shane, I believe you know something about this area of the code, do you know why we'd prefer one over the other, should we add in an extra result for Hello which would return the real document.title in addition to the og:title?

Comment 3

[Mark Banner (:standard8)]

Also, to clarify the bug, this will only happen on pages that are specifying their open graph document title to be different to that of the page's document title.

Comment 4

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Let's track for FF42 and FF41.

Comment 5

[Shane Caraveo (:mixedpuppy)]

Probably should remove any overwrites that og: data does, which happens here:

https://mxr.mozilla.org/mozilla-central/source/toolkit/modules/PageMetadata.jsm#182

This doesn't however prevent the opposite, a site that enhances titles in og data but not in title.  The web is messy.

Comment 6

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Mark, here is another one. I do not consider this release blocking and would like to wontfix for FF41 and untrack. We can track it for 42 and consider fixing it there. Do you agree? Or is this an easy to fix issue? Thanks.

Comment 7

[Mark Banner (:standard8)]

Attachment: When obtaining page metadata, always prefer the page title over the opengraph title.

This fixes the issue - ensure's we use the page title, rather than the opengraph title. I've also included some unit tests for this.

Comment 8

[Mark Banner (:standard8)]

(In reply to Ritu Kothari (:ritu) from comment #6)
> Mark, here is another one. I do not consider this release blocking and would
> like to wontfix for FF41 and untrack. We can track it for 42 and consider
> fixing it there. Do you agree? Or is this an easy to fix issue? Thanks.

Patch is now up & simple. However, I'm fine with making this tracking 42, and if it lands in time then uplifting to 41 as well.

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/b3290a39dcba

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b3290a39dcba

Comment 11

[Mark Banner (:standard8)]

Comment on attachment 8653426 [details] [diff] [review]
When obtaining page metadata, always prefer the page title over the opengraph title.

Approval Request Comment
[Feature/regressing bug #]: Context in conversations for Hello.
[User impact if declined]: When attaching context to a conversation, some page titles may be missing information/not have the same title that the user would expect.
[Describe test coverage new/current, TreeHerder]: Has text coverage for the change, landed in m-c.
[Risks and why]: Low for the code change. Context is a recently released feature, and getting the right title is important.
[String/UUID change made/needed]: None

Note: I'm only requesting uplift to aurora as this could have impacts on other areas of the browser using the title. I don't think there will be adverse impacts from what I know of the places this code is used, but just in case, I think it might be better to play safe and give it a full cycle on beta.

Comment 12

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8653426 [details] [diff] [review]
When obtaining page metadata, always prefer the page title over the opengraph title.

Improve a feature, taking it.
Make sense to only take it in aurora.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/3eedcbc969ed

Comment 14

[Ian Bicking (:ianbicking)]

Proposal to put back og:title created in Bug 1252502