1174341 - only treat emphasis markdown based on spaces

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Albert Ting]

Currently the empahsis markdown feature looks for underscores after a non-word.  Instead, it should be after a space or newline.

For example, this comment below:

   <prefix>_bar.c and <prefix>_bif.c

gets converted to below (with the underscore removed, and italicized)

   <prefix>bar.c and <prefix>bif.c
           |-- italicized --| 

I agree using code blocks could solve this, but it's not intuitive.

Comment 1

[Albert Ting]

Attachment: v1

I took a stab at fixing this.  The patch essentially changes the starting character from \W to \s.  This seems to work for me.

Comment 2

[Albert Ting]

Attachment: 101emphasis.t

I've attached the test case I'm using for this patch

Comment 3

[Frédéric Buclin]

We should have one single 100markdown.t test script, IMO. I'm really not a fan of having tons of markdown test scripts. For instance, we have one single 007util.t test script to test subroutines from Bugzilla::Util.

Comment 4

[Dylan Hardison [:dylan] (he/him)]

I agree, it should be in 100markdown.t.

Comment 5

[Koosha KM]

Due to its complicated structure, the markdown is so vulnerable to further bugs when one bug gets fixed. Thus, I believe that there should be a separate bug addressing different test cases as a test script for markdown.

Comment 6

[Gervase Markham [:gerv]]

Attachment: Patch v.2

Here's a version with an updated 100markdown.t which reads .md files from a subdirectory and tests them. So adding new tests just means adding a new .md file to the subdirectory. The files are self-documenting - markdown above the "---", actual HTML below it. (This works because Markdown is allowed to contain HTML.) This means you can also view or process the .md file in other processors to see how they handle the same markup.

Gerv

Comment 7

[Dylan Hardison [:dylan] (he/him)]

I suspect I bit-rotted part of this with my fix in bug 1294569, but I wanted to say that this is a great improvement in testing. Thanks gerv!

Comment 8

[Gervase Markham [:gerv]]

dylan: you're welcome; feel free to give it r+ :-)

Gerv

Comment 9

[Gervase Markham [:gerv]]

Attachment: Patch v.3

Unbitrotted.

Gerv

Comment 10

[Gervase Markham [:gerv]]

dylan: any plans to review? :-)

Gerv

Comment 11

[Dylan Hardison [:dylan] (he/him)]

Comment on attachment 8790326 [details] [diff] [review]
Patch v.3

r=dylan

Comment 12

[Dylan Hardison [:dylan] (he/him)]

Actually this used File::Slurp which only works because the jobqueue depends on it still, but I'll fix on commit.

Comment 13

[Dylan Hardison [:dylan] (he/him)]

To github.com:bugzilla/bugzilla.git
   4480c8ca9..d04520659  master -> master