Closed Bug 1174353 Opened 9 years ago Closed 9 years ago

HTTP 500 INTERNAL SERVER ERROR in Review Board

Categories

(MozReview Graveyard :: General, defect, P1)

Product:
MozReview Graveyard
Component:
General
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: jib, Assigned: smacleod)

References

Details

Got this error on https://reviewboard.mozilla.org/r/10713/# after pushing a bunch of mq patches to review for the third time (first push had been published and reviewed with r+. Second push was pending with one additional patch and never published. I fixed one more bug and pushed a third time. The error seems permanent. :-( Error:

Well, this is embarassing...

Something's gone wrong in either retrieving or manipulating these review requests. Sorry about that. Please consider filing a bug, and including the following information:

HTTP 500 INTERNAL SERVER ERROR

reportError@https://reviewboard.mozilla.org/static/ext/mozreview.extension.MozReviewExtension/js/reviews.min.eb256efb84ea.js:1:1163
CommitListView<.initialize/<.error@https://reviewboard.mozilla.org/static/ext/mozreview.extension.MozReviewExtension/js/reviews.min.eb256efb84ea.js:1:8754
RB.DraftResourceModelMixin._retrieveDraft/<.error@https://reviewboard.mozilla.org/static/rb/js/base.min.6b96c3eb4ed5.js:1:29663
R/e.error@https://reviewboard.mozilla.org/static/lib/js/3rdparty.min.41a088aa2665.js:4:12836
RB.BaseResource<.sync/syncOptions.error<@https://reviewboard.mozilla.org/static/rb/js/base.min.6b96c3eb4ed5.js:1:26320
p.Callbacks/k@https://reviewboard.mozilla.org/static/lib/js/jquery-1.8.2.min.cfa9051cc0b0.js:2:16915
p.Callbacks/l.fireWith@https://reviewboard.mozilla.org/static/lib/js/jquery-1.8.2.min.cfa9051cc0b0.js:2:17707
y@https://reviewboard.mozilla.org/static/lib/js/jquery-1.8.2.min.cfa9051cc0b0.js:2:80827
.send/d@https://reviewboard.mozilla.org/static/lib/js/jquery-1.8.2.min.cfa9051cc0b0.js:2:86374

Stack
Close
I don't see it either logged in or logged out :/

Try force refresh via shift reload?
Flags: needinfo?(jib)
I'm also unable to publish (nothing happens) or discard the draft (same 500 error in a popup this time), so that's probably why no-one else can see it.

What do you mean force refresh? In the browser? Tried that. Even tried different browser. Seems permanent.
Flags: needinfo?(jib)
Really strange error:

Traceback (most recent call last):
File "/data/www/reviewboard.mozilla.org/venv/lib/python2.6/site-packages/django/core/handlers/base.py", line 199, in get_response response = middleware_method(request, response)
File "/usr/lib64/python2.6/site-packages/newrelic-2.44.0.36/newrelic/hooks/framework_django.py", line 329, in wrapper return wrapped(*args, **kwargs)
File "/data/www/reviewboard.mozilla.org/venv/lib/python2.6/site-packages/django/middleware/http.py", line 14, in process_response response['Content-Length'] = str(len(response.content))
File "/data/www/reviewboard.mozilla.org/venv/lib/python2.6/site-packages/djblets/webapi/responses.py", line 109, in _get_content **self.encoder_kwargs)
File "/data/www/reviewboard.mozilla.org/venv/lib/python2.6/site-packages/djblets/webapi/encoders.py", line 110, in encode return super(JSONEncoderAdapter, self).encode(o)
File "/usr/lib64/python2.6/json/encoder.py", line 367, in encode chunks = list(self.iterencode(o))
File "/usr/lib64/python2.6/json/encoder.py", line 309, in _iterencode for chunk in self._iterencode_dict(o, markers):
File "/usr/lib64/python2.6/json/encoder.py", line 275, in _iterencode_dict for chunk in self._iterencode(value, markers):
File "/usr/lib64/python2.6/json/encoder.py", line 309, in _iterencode for chunk in self._iterencode_dict(o, markers):
File "/usr/lib64/python2.6/json/encoder.py", line 275, in _iterencode_dict for chunk in self._iterencode(value, markers):
File "/usr/lib64/python2.6/json/encoder.py", line 306, in _iterencode for chunk in self._iterencode_list(o, markers):
File "/usr/lib64/python2.6/json/encoder.py", line 204, in _iterencode_list for chunk in self._iterencode(value, markers):
File "/usr/lib64/python2.6/json/encoder.py", line 317, in _iterencode for chunk in self._iterencode_default(o, markers):
File "/usr/lib64/python2.6/json/encoder.py", line 309, in _iterencode for chunk in self._iterencode_dict(o, markers):
File "/usr/lib64/python2.6/json/encoder.py", line 275, in _iterencode_dict for chunk in self._iterencode(value, markers):
File "/usr/lib64/python2.6/json/encoder.py", line 306, in _iterencode for chunk in self._iterencode_list(o, markers):
File "/usr/lib64/python2.6/json/encoder.py", line 204, in _iterencode_list for chunk in self._iterencode(value, markers):
File "/usr/lib64/python2.6/json/encoder.py", line 317, in _iterencode for chunk in self._iterencode_default(o, markers):
File "/usr/lib64/python2.6/json/encoder.py", line 323, in _iterencode_default newobj = self.default(o)
File "/data/www/reviewboard.mozilla.org/venv/lib/python2.6/site-packages/djblets/webapi/encoders.py", line 118, in default **self.encode_kwargs)
File "/data/www/reviewboard.mozilla.org/venv/lib/python2.6/site-packages/djblets/webapi/responses.py", line 88, in encode result = encoder.encode(*args, **kwargs)
File "/data/www/reviewboard.mozilla.org/venv/lib/python2.6/site-packages/djblets/webapi/encoders.py", line 87, in encode return serializer.serialize_object(o, *args, **kwargs)
File "/data/www/reviewboard.mozilla.org/venv/lib/python2.6/site-packages/ReviewBoard-2.0.16-py2.6.egg/reviewboard/webapi/resources/user.py", line 95, in serialize_object del data[field]
KeyError: u'email'
(In reply to Jan-Ivar Bruaroey [:jib] from comment #2)
> I'm also unable to publish (nothing happens) or discard the draft (same 500
> error in a popup this time), so that's probably why no-one else can see it.
> 
> What do you mean force refresh? In the browser? Tried that. Even tried
> different browser. Seems permanent.

Can you try logging out and back in again?
Flags: needinfo?(jib)
I've logged out of both bugzilla and review board and logged back in, and it's still there.
Flags: needinfo?(jib)
(In reply to Jan-Ivar Bruaroey [:jib] from comment #6)
> I've logged out of both bugzilla and review board and logged back in, and
> it's still there.

I forced a publish on it. Are you still getting errors when viewing it?
Flags: needinfo?(jib)
Now it seems to work. Thanks!
Flags: needinfo?(jib)
I spoke too soon. I tried to add jesup as a reviewer to the last patch, hit "Publish Review" and the error and the red box is back. :-(
Is there any way you can force-push it again? That way jesup can at least see the diffs which would be super valuable!
Flags: needinfo?(smacleod)
I guess a second force-push isn't necessary since I realized I'm the only one seeing the busted draft, and I can log out of Review board and see the diffs, so jesup should be fine viewing the diffs at least (as long as he doesn't touch anything I suspect)
Flags: needinfo?(smacleod)
Can you go to https://reviewboard.mozilla.org/account/preferences/#profile and uncheck "Keep profile information private" (This will allow your bugzilla email address to be viewed by anonymous visitors) and see if you're able to perform operations after that?
Flags: needinfo?(jib)
I tried it and it did not seem to make a difference. I tried logging out and back in right after as well.

I've set the setting back to private.
Flags: needinfo?(jib)
Seeing the same stack after pushing a dependent bug.

i.e. I have

central -- (a bunch of changesets) --> bug A -- (a bunch of changesets) --> bug B

I have a bookmark at bug A and bug B

I did:

  hg update bugA
  hg push review
  (publish review, update central, rebase bugB)
  hg update bugB
  hg push review

And now I see the same error message and stack.
When I go to discard draft I just get a Javascript alert that says 'HTTP 500 INTERNAL SERVER ERROR'
This is a P1 since multiple people are seeing the error and it prevents people from using MozReview.
Priority: -- → P1
FWIW I may have experimented with bookmarks as well when I first saw this problem, but I'm also using mq, and have qpop/qpushed, which seems to have erased my bookmarks (I no longer see them in my hg bookmarks). Not sure if that's any clue.
I believe I've tracked down the root of the problem (it appears to be a bug in Core Review Board that was introduced with 2.0.16). I'm coordinating to get a fix released ASAP and will post updates here.

In the mean time, there really isn't a great workaround - if you hit this let me know and I can try some manual intervention to get things published for you.
Assignee: nobody → smacleod
Status: NEW → ASSIGNED
We'll have this fixed up today and a release out by tonight. We've been tracking down the core issue to ensure it'll be properly fixed with a working unit test. Sorry for the inconvenience, everyone.
Fix for this has been released, update to vct pushed as https://hg.mozilla.org/hgcustom/version-control-tools/rev/d923f5508e55

Will be deployed soon.
The update has been deployed to production. jib, can you confirm this is fixed?
Flags: needinfo?(jib)
Deployed.

Please reopen if this isn't fixed.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Works for me, thanks! (pushed review on Bug 1173255 and it worked fine)
Flags: needinfo?(jib)
Product: Developer Services → MozReview
You need to log in before you can comment on or make changes to this bug.