1174528 - Bookmarks sidebar panel is empty in non-browser windows

Status: VERIFIED FIXED

(SeaMonkey :: Sidebar, defect)

Description

[exalm7659]

Attachment: Screenshot

Bookmarks sidebar panel is empty in Composer or in Mail Compose.
Error console:
Error: TypeError: window.top.PlacesUIUtils is undefined
Source File: chrome://communicator/content/bookmarks/bm-panel.js
Line: 7

It seems to be just a typo, since PlacesUIUtils get imported in the bm-panel.js itself, but it uses the one from Browser window instead.

Comment 1

[exalm7659]

Attachment: fix-bookmark-sidebar.patch

A possible fix.

Comment 2

[exalm7659]

Attachment: Screenshot of the patch

Comment 3

[Rainer Bielefeld]

@Reporter:
Please contribute information concerning your OS, MS Version and so on so that other users can find out whether they suffer from the same problem.

Comment 4

[Rainer Bielefeld]

REPRODUCIBLE with EN-US SeaMonkey 2.33.1 (German Language pack)  Gecko/20100101 Build 20150321194901 (Classic Theme) on German WIN7 64bit:

1. Launch Email client
2. Click Icon 'Compose'
   » Mail Composer (here: Text e-mails) will open
3. <f9> if necessary to show sidebar
4. Click Sidebar Panel 'bookmarks': 
 » is empty (Although in Browser all bookmarks are shown)

Additional info:
a) Already reproducible with 2.29.1, 2.26
b) Was still ok with 2.0
c) Still a problem with EN-US SeaMonkey 2.38a1 build by Philip Chee, Gecko/20100101 , Build 20150601233926 (Classic Theme) on German WIN7 64bit
d) no DUPs found in <https://bugzilla.mozilla.org/buglist.cgi?cmdtype=runnamed&namedcmd=DUPs1174528&list_id=12326886>

Comment 5

[exalm7659]

(In reply to Rainer Bielefeld from comment #3)
> @Reporter:
> Please contribute information concerning your OS, MS Version and so on so
> that other users can find out whether they suffer from the same problem.

Umm, I'm not sure how do I mark that it is reproducible on multiple versions? I was able to reproduce it on 2.33.1 and 2.38a1 and I remember it for being there for much longer time.
Same for platforms: Linux x86, Linux x86_64, Windows XP x86.

Comment 6

[Rainer Bielefeld]

(In reply to exalm7659 from comment #5)
> Umm, I'm not sure how do I mark that it is reproducible on multiple
> versions? 

The interesting VERSION is the earliest one where the bug can be reproduced, that helps to find the code change with what a regression has been introduced. The tracking flag confirms that the problem still does exist in 2.38.

I hope we will get a review, soon

Comment 7

[exalm7659]

Okay. In this case it's 2.1, the version in which Places-based bookmarks were introduced. Just checked, the bug is there with clean profile.

Comment 8

[exalm7659]

Okay. In this case it's 2.1, the version in which Places-based bookmarks were introduced. Just checked, the bug is there with clean profile.

Comment 9

[Philip Chee]

Comment on attachment 8622078 [details] [diff] [review]
fix-bookmark-sidebar.patch

You need to request review otherwise nobody will notice this patch.
Plus you need to request review from someone.

Comment 10

[Philip Chee]

Comment on attachment 8622078 [details] [diff] [review]
fix-bookmark-sidebar.patch

Looks reasonable. r=me

Comment 11

[exalm7659]

Umm, even though you have already reviewed it, how do I do it? Sorry, I'm a complete novice in Bugzilla...

Comment 12

[Rainer Bielefeld]

(In reply to exalm7659 from comment #11)
> Umm, even though you have already reviewed it, how do I do it? Sorry, I'm a
> complete novice in Bugzilla...

Simply write down the facts in a comment, someone else can handle the dashboard.

Comment 13

[exalm7659]

Wait, did I accidentally remove Philip's changes to dashboard by commenting after his comment?
How to revert it?..

Comment 14

[exalm7659]

Thanks. :)

Comment 15

[Philip Chee]

Comment on attachment 8622078 [details] [diff] [review]
fix-bookmark-sidebar.patch

[Approval Request Comment]
Regression caused by (bug #): migration to Places Bookmarks
User impact if declined: Blank Bookmarks panel in sidebar.
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky): no risk. one line bug fix.
String changes made by this patch: none.

Comment 16

[Philip Chee]

http://hg.mozilla.org/comm-central/rev/1e54d458daa6          SeaMonkey 2.39
http://hg.mozilla.org/releases/comm-aurora/rev/b66fc99534fb  SeaMonkey 2.38
http://hg.mozilla.org/releases/comm-beta/rev/7c824ad0d169    SeaMonkey 2.37
http://hg.mozilla.org/releases/comm-release/rev/c47294304732 SeaMonkey 2.36 (which was comm-beta)

Comment 17

[Philip Chee]

[needs approval for SeaMonkey 2.35]

Comment 18

[Philip Chee]

Pushed to SEAMONKEY_2_35_RELEASE_BRANCH on comm-release
http://hg.mozilla.org/releases/comm-release/rev/c83915eb91a0

/me sighs. noticed I forgot to put the bug number in the commit messages.

Comment 19

[Rainer Bielefeld]

VERIFIED with DE SeaMonkey 2.35  (Windows NT 6.1; WOW64; rv:38.0 nightly by Philip Chee)  Gecko/20100101 Build 20150722220804 (Classic Theme) on German WIN7 64bit