Closed
Bug 1175057
Opened 9 years ago
Closed 9 years ago
[Wifi] Script timeout in test_wifi_static_ip.js (breaked by bug 1166660)
Categories
(Firefox OS Graveyard :: Wifi, defect, P2)
Tracking
(firefox43 fixed)
RESOLVED
FIXED
FxOS-S7 (18Sep)
Tracking | Status | |
---|---|---|
firefox43 | --- | fixed |
People
(Reporter: edgar, Assigned: timhuang)
References
Details
Attachments
(1 file, 2 obsolete files)
3.00 KB,
patch
|
timhuang
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a follow-up of Bug #1166660 +++ I found the changes in bug 1166660 break the test_wifi_static_ip.js test. [1] https://treeherder.mozilla.org/#/jobs?repo=b2g-inbound&revision=3fb87cd8044c&exclusion_profile=false&filter-searchStr=mnw
Reporter | ||
Comment 1•9 years ago
|
||
Using the custom hostapd instead of stock hostapd (like we did in bug 1166660) can also fix this, but I am not sure if this is a good idea to fix it.
Comment 2•9 years ago
|
||
It seems while running 'test_wifi_static_ip.js', there are 4 APs out there (supposed to have only the stock AP). I believe I didn't deal with stock AP very well when fixing KK emulator. Since the use of stock AP has been removed in order to fix KK emulator test cases, this issue will be only observed in this test case.
Comment 3•9 years ago
|
||
(In reply to Edgar Chen [:edgar][:echen] from comment #1) > Created attachment 8623451 [details] [diff] [review] > Patch, v1 > > Using the custom hostapd instead of stock hostapd (like we did in bug > 1166660) can also fix this, but I am not sure if this is a good idea to fix > it. Oops! I think it is just because all the APs are killed in the previous test case (test_wifi_auto_connect.js). Pushed a patch to try. The patch simply restart hostapd every time we are about to run a test case chain. https://treeherder.mozilla.org/#/jobs?repo=try&revision=e5a9e0a6d5ac
Updated•9 years ago
|
Priority: -- → P2
Assignee | ||
Comment 4•9 years ago
|
||
Attachment #8655313 -
Flags: review?(hchang)
Assignee | ||
Updated•9 years ago
|
Attachment #8655313 -
Attachment description: Fix the problem of the script timeout by ensuring it associates to the right ap. → Bug-1175057.patch
Assignee | ||
Comment 5•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d6c6b7f992a3
Comment 6•9 years ago
|
||
Comment on attachment 8655313 [details] [diff] [review] Bug-1175057.patch Review of attachment 8655313 [details] [diff] [review]: ----------------------------------------------------------------- It looks pretty good :) Let's wait for the try run result!
Attachment #8655313 -
Flags: review?(hchang) → review+
Reporter | ||
Comment 7•9 years ago
|
||
Right now, the marionette-webapi is broken by https://bugzilla.mozilla.org/show_bug.cgi?id=1050749#c44 :(. You can push to try again after it is fixed.
Reporter | ||
Comment 8•9 years ago
|
||
Bug 1200960 is landed, you can try it again with latest gecko. ;)
Reporter | ||
Updated•9 years ago
|
Attachment #8623451 -
Attachment is obsolete: true
Assignee | ||
Comment 9•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ba8ff777c1bd
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → tihuang
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 10•9 years ago
|
||
Attachment #8656939 -
Flags: review+
Assignee | ||
Updated•9 years ago
|
Attachment #8655313 -
Attachment is obsolete: true
Comment 11•9 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/7d271e866fa2
Keywords: checkin-needed
Comment 12•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/7d271e866fa2
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S7 (18Sep)
You need to log in
before you can comment on or make changes to this bug.
Description
•