1175094 - <select> dropdown arrow is horizontally misaligned when RTL dilection on Windows7 Classic

Status: VERIFIED FIXED

(Core :: Layout: Form Controls, defect)

Description

[Alice0775 White]

Attachment: select_rtl.html

[Tracking Requested - why for this release]: Regression

This is regression since Nightly41.0a1.
This happens with/without e10s.

Steps To Reproduce:
1. Open attached

Actual Results:
<select> dropdown arrow is horizontally misaligned 
See screenshot

Comment 1

[Alice0775 White]

Attachment: screenshot

Comment 2

[Alice0775 White]

Regression window:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=3324527b41cc&tochange=c53efb981810

Triggered by: Bug 1113206

Comment 3

[Kate Glazko]

Matt, could you please let us know if this is by design or a UI bug? Is this something we want to fix in 41?

Comment 4

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Adding a tracking flag for FF41. Matt, if this is by design, please let us know.

Comment 5

[Matt Woodrow (:mattwoodrow)]

I have no idea, this seems more like a question for Simon.

Comment 6

[Simon Montagu :smontagu]

No, this isn't by design. 

The bug is presumably in setting buttonRect.x inside nsComboboxControlFrame::Reflow, where I removed the special-casing for RTL.

Unfortunately the bug isn't reproducible on OSX and I won't have access to a developing environment on Windows in the next two months. Jonathan, can you take this on?

Comment 7

[Jonathan Kew [:jfkthame]]

I'll try to take a look soon.

Comment 8

[blinky]

This also happens in https://dl.dropboxusercontent.com/u/95157096/85f61cf7/j3rap7updi.html.

Comment 9

[Jonathan Kew [:jfkthame]]

Attachment: Include borderPadding in the combobox's containerWidth, so that dropdown arrow is positioned correctly in RTL

I think this one is simple: we're supposed to include the borderPadding with the computedWidth as containerWidth, just like we do in lots of other places. (Bug 1177614 will provide a utility function to replace this, but for now let's try the fix here.)

Comment 10

[Jonathan Kew [:jfkthame]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ed12d4950457

Comment 11

[Simon Montagu :smontagu]

Comment on attachment 8631627 [details] [diff] [review]
Include borderPadding in the combobox's containerWidth, so that dropdown arrow is positioned correctly in RTL

Review of attachment 8631627 [details] [diff] [review]:
-----------------------------------------------------------------

Makes sense

Comment 12

[Jonathan Kew [:jfkthame]]

This appears to fix the problem for me on Win8. Alice0775, if you could confirm it also resolves the issue for you, that would be great -- thanks. Tryserver build is currently in progress (comment 10).

Comment 13

[Alice0775 White]

Confirmed.
The try-server build fixes the problem on Windows7 Classic.
https://hg.mozilla.org/try/rev/e275e33d0e11
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:42.0) Gecko/20100101 Firefox/42.0 ID:20150709090503

Comment 14

[Jonathan Kew [:jfkthame]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/aef99fde8ffe

Comment 15

[Jonathan Kew [:jfkthame]]

Comment on attachment 8631627 [details] [diff] [review]
Include borderPadding in the combobox's containerWidth, so that dropdown arrow is positioned correctly in RTL

Approval Request Comment
[Feature/regressing bug #]: 1113206
[User impact if declined]: minor visual glitch in RTL comboboxes on some platforms/themes
[Describe test coverage new/current, TreeHerder]: tested locally, confirmed by reporter using tryserver build
[Risks and why]: minimal risk: minor adjustment to metrics within combobox layout, no wider effects
[String/UUID change made/needed]: none

Comment 16

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/aef99fde8ffe

Comment 17

[Kate Glazko]

Comment on attachment 8631627 [details] [diff] [review]
Include borderPadding in the combobox's containerWidth, so that dropdown arrow is positioned correctly in RTL

Approving for uplift to Aurora because minimal risk, changes are only made to combobox container.

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/d1d1000403e5

Comment 19

[Valentina Virlics [:vvalentina], Ecosystem QA]

Please see the screenshot from https://bugzilla.mozilla.org/show_bug.cgi?id=1177660#c8 ... because I can also reproduce the issue with the misaligned drop-down arrow, in (RTL) FF OS. 

I don't now if the issue from FF OS and this one from Win7 have the same root. Please let me know if another bug should be filled. 
Thank you!

Comment 20

[Jonathan Kew [:jfkthame]]

It's possible the FFOS issue will have been fixed by this patch, but I'm not entirely sure. It would be best to test a current trunk build on a device to verify whether it is fixed.

Comment 21

[Valentina Virlics [:vvalentina], Ecosystem QA]

Unfortunately, the drop-down arrow is still misaligned in FF OS 2.0 (build: 20150716000204)
What should be do next? 
Thanks!

Comment 22

[Jonathan Kew [:jfkthame]]

(In reply to ValentinaP from comment #21)
> Unfortunately, the drop-down arrow is still misaligned in FF OS 2.0 (build:
> 20150716000204)
> What should be do next? 

I doubt FF OS 2.0 builds are using gecko trunk; I think you'll need to test a build with current gecko from mozilla-central to see if the fix here helps.

Comment 23

[Valentina Virlics [:vvalentina], Ecosystem QA]

We tested on FF OS 2.5 (build: eng.cltbld.20150213.031717, the last build available on mozilla-central), and there is no arrow for the drop-down....so I suppose the fix erased the drop-down arrow?
I checked in Marketplace-stage and in AMO-dev.
Please see the screenshot: http://screencast.com/t/5LHVgfcdpQEc

Comment 24

[Jonathan Kew [:jfkthame]]

That doesn't sound like the desired behavior. It could be either a Gecko or Gaia bug; further investigation needed. Please file a new bug.

Comment 25

[Valentina Virlics [:vvalentina], Ecosystem QA]

(In reply to Jonathan Kew (:jfkthame) from comment #24)
> That doesn't sound like the desired behavior. It could be either a Gecko or
> Gaia bug; further investigation needed. Please file a new bug.

Thanks for the answer.

Comment 26

[Russell]

I have reproduced the bug with Nightly of 41.0a1 (2015-06-16) on my Windows 7, 64 Bit!

The bug's fix is verified now on Latest Nightly 43.0a1!

Build ID 20150816091433
User Agent Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:43.0) Gecko/20100101 Firefox/43.0

[testday-20150821]

Comment 27

[Nazir Ahmed Sabbir [:NaSb]]

Successfully reproduce this bug on Nightly 41.0a1 (2015-06-16) (Build ID: 20150616030201) with the instruction from comment 0 on Linux x64

This Bug is now verified as fixed on Latest Developer Edition 42.0a2 (2015-09-05) (Build ID: 20150905004017) and
Latest Beta 41.0b7 (Build ID: 20150903133607)

Mozilla/5.0 (X11; Linux x86_64; rv:42.0) Gecko/20100101 Firefox/42.0
Mozilla/5.0 (X11; Linux x86_64; rv:41.0) Gecko/20100101 Firefox/41.0

As it is also verified on Windows (Comment 26), Marking it as verified!