Closed Bug 1175410 Opened 9 years ago Closed 9 years ago

Update comm-central for PLDHashTable changes in bug 1174625

Categories

(MailNews Core :: Backend, defect)

Product:
MailNews Core
Component:
Backend
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 41.0

People

(Reporter: n.nethercote, Assigned: n.nethercote)

References

Details

Attachments

(1 file)

Update comm-central for PLDHashTable changes in bug 117462
7.00 KB, patch
rkent
: review+
Details | Diff | Splinter Review 
Bug 1174625 tweaked the API of PLDHashTable's iterator.
The changes within TokenEnumeration are simple.

The changes in observeMessage() are a little more complex.
PLDHashTable::Iterator no longer has a copy constructor, so instead of creating
a long-lived TokenEnumeration at the start and then passing a copy to each call
to forgetToken() and rememberToken(), instead we pass the Tokenizer and create
from it a new short-lived TokenEnumeration within forgetToken() and
rememberToken(). IMO the new code is easier to understand because the
TokenEnumerations are shorter-lived.

I've checked the new code compiles, but I haven't tested it in any way.
Attachment #8623531 - Flags: review?(rkent)
Assignee: nobody → n.nethercote
Status: NEW → ASSIGNED
Comment on attachment 8623531 [details] [diff] [review]
Update comm-central for PLDHashTable changes in bug 117462

Looks good to me. Thanks for fixing comm-central!
Attachment #8623531 - Flags: review?(rkent) → review+
https://hg.mozilla.org/comm-central/rev/ace4d457e63a
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 41.0
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: