1175756 - Change JIT Optimizations to be a view option rather than a recording feature

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect)

Description

[Jordan Santell [:jsantell] [@jsantell]]

With bug 1175705, this has optimizations as a per-recording basis, like the other settings which optionally record memory, allocations, framerate, etc, rather than a visual toggle. This lets us not do extra work on the client to assemble optimization data, and an opportunity to not send opt data over the wire.

Is this an option we can add to the profiler? This does mean previous recordings with opt data will not be shown unless the recording was marked with having opt data.

Comment 2

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: 1175756-jit-opts-pref.patch

https://treeherder.mozilla.org/#/jobs?repo=try&revision=11330b93e1e7

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/07f9be6ddc8d

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/07f9be6ddc8d

Comment 5

[Ton [:Tonnes]]

(In reply to Phil Ringnalda (:philor) from comment #4)
> https://hg.mozilla.org/mozilla-central/rev/07f9be6ddc8d
> -<!ENTITY performanceUI.enableJITOptimizations.tooltiptext "Record JIT optimization data sampled in each JavaScript frame.">
> +<!ENTITY performanceUI.showJITOptimizations.tooltiptext "Show JIT optimization data sampled in each JavaScript frame.">

Please do not use trailing periods in tooltips unless 2 or more lines are involved, as mentioned in other Devtools bugs. Tooltips should never end with a period in order to avoid implying use of imperative mood (=instruction to user), which is valid for English as well as for localizers who keep running into this issue and wonder what verbs to use, especially in Devtools files.

It would be nice to see them all cleared "when at it" (when someone is working on a Devtools file), and someone doing QA watching for this.

See https://bugzilla.mozilla.org/show_bug.cgi?id=1163763#c39.