Closed
Bug 1175786
Opened 9 years ago
Closed 9 years ago
Rewrite test_mediaElementAudioSourceNodeCrossOrigin.html to be less machine-loading dependent
Categories
(Core :: Web Audio, defect)
Core
Web Audio
Tracking
()
RESOLVED
FIXED
mozilla41
Tracking | Status | |
---|---|---|
firefox41 | --- | fixed |
People
(Reporter: jwwang, Assigned: jwwang)
Details
Attachments
(1 file)
2.02 KB,
patch
|
padenot
:
review+
|
Details | Diff | Splinter Review |
See https://bugzilla.mozilla.org/show_bug.cgi?id=1169356#c70. Since bug 1174077 is landed, we are now able to play a captured media element till the end even if it is playing a CORS resource. We can now re-write test_mediaElementAudioSourceNodeCrossOrigin.html by checking if we get silence as expected before the end of playback without depending on the heuristic loop count.
Assignee | ||
Comment 1•9 years ago
|
||
Try looks green. https://treeherder.mozilla.org/#/jobs?repo=try&revision=38839aa04595 No failures in test_mediaElementAudioSourceNodeCrossOrigin.html in about 150 runs.
Comment 2•9 years ago
|
||
Comment on attachment 8624008 [details] [diff] [review] 1175786_rewrite_testcase-v1.patch Review of attachment 8624008 [details] [diff] [review]: ----------------------------------------------------------------- Thanks !
Attachment #8624008 -
Flags: review?(padenot) → review+
Assignee | ||
Comment 3•9 years ago
|
||
Thanks for the review!
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Comment 5•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/39e7b3bc8ff7
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in
before you can comment on or make changes to this bug.
Description
•