1175811 - [RTL][Settings]Display of comma follows the LTR way in language settings view.

Status: VERIFIED FIXED

(Mozilla Localizations :: ar / Arabic, defect)

Description

[Sue]

Attachment: comma in language settings.png

[1.Description]:
[RTL][Flame 2.2&3.0][Nexus5 2.2&3.0][Settings]Display of comma does not follow the RTL way in language settings view.
See attachment: comma in language settings.png

[2.Testing Steps]: 
Prerequisite: Set system language as Arabic.
1. Launch Settings.
2. Select Language.
3. Observe the Comma which is used for separating the date.

[3.Expected Result]: 
3. Comma should be displayed in RTL way like that in Calendar.

[4.Actual Result]: 
3. Comma is shown in LTR way.

[5.Reproduction build]: 
Device: Flame 2.2 (affected)
Build ID               20150617002504
Gaia Revision          3414b07dc489976bf510fd8042c0af3b1192c160
Gaia Date              2015-06-16 22:04:56
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/a2db74491088
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150617.040422
Firmware Date          Wed Jun 17 04:04:34 EDT 2015
Bootloader             L1TC000118D0

Device: Flame 3.0 (affected)
Build ID               20150617160207
Gaia Revision          b404c41c5471c31610e64defb74ec066b411e724
Gaia Date              2015-06-17 17:01:15
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/a3f280b6f8d5
Gecko Version          41.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150617.192003
Firmware Date          Wed Jun 17 19:20:14 EDT 2015
Bootloader             L1TC000118D0

Device: Nexus 5 2.2 (affected)
Build ID               20150617002504
Gaia Revision          3414b07dc489976bf510fd8042c0af3b1192c160
Gaia Date              2015-06-16 22:04:56
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/a2db74491088
Gecko Version          37.0
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150617.042332
Firmware Date          Wed Jun 17 04:24:07 EDT 2015
Bootloader             HHZ12f

Device: Nexus 5 3.0 (affected)
Build ID               20150617160207
Gaia Revision          b404c41c5471c31610e64defb74ec066b411e724
Gaia Date              2015-06-17 17:01:15
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/a3f280b6f8d5
Gecko Version          41.0a1
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150617.192258
Firmware Date          Wed Jun 17 19:23:17 EDT 2015
Bootloader             HHZ12f

[6.Reproduction Frequency]: 
Always Recurrence,5/5

[7.TCID]: 
Free Test

Comment 1

[Delphine Lebédel [:delphine - Use needinfo]]

Rami: is this a comma you can change on l10n side?

Comment 2

[Delphine Lebédel [:delphine - Use needinfo]]

Or maybe Linostar can confirm?

Comment 3

[Anas Husseini [:linostar]]

Yes, this is fixable. I believe the corresponding string is in the file apps/calendar/calendar.properties: 

longDateFormat=%A, %d %B, %Y

It should be latered to:

longDateFormat=%A، %d %B، %Y


And while we're at it, there is a similar string (with the same name) in another file that should be changed likewise. It is in apps/settings/settings.properties

Comment 4

[Anas Husseini [:linostar]]

*altered

Note that the string in apps/settings/settings.properties has another error which is the reverse order of day and month. It is currently set to "%A, %B %d, %Y", so it should become "%A، %d %B، %Y".

Comment 5

[Delphine Lebédel [:delphine - Use needinfo]]

Moving over to l10n component so this can get a fix.

Comment 6

[Delphine Lebédel [:delphine - Use needinfo]]

rami, could you take a look at this please? :D
(see comment 3 and comment 4). thanks!

Comment 7

[Rami Khader]

I corrected the comma

Comment 8

[Shine(Leave from Mozilla)]

Attachment: Flame_master_Verify1.png

This problem is verified as "pass" on latest build of Flame 2.2/master and N5 2.2/master.
Actual result: The comma in language settings view are displayed in RTL way like that in Calendar.
See attachment: Flame_master_Verify1.png
Rate: 0/5

Device information:
Flame 2.2: (Pass)
Build ID               20150715002506
Gaia Revision          84d0c76370dcd3d25813b00de55194730884355b
Gaia Date              2015-07-09 13:09:14
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/a5db6d9850f6
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150715.040736
Firmware Date          Wed Jul 15 04:07:49 EDT 2015
Bootloader             L1TC000118D0

Flame master: (Pass)
Build ID               20150715160204
Gaia Revision          b9968cdc4a1dee49848fed6159a59c378cea062d
Gaia Date              2015-07-15 12:13:34
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/49683d4e9ebd
Gecko Version          42.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150715.192231
Firmware Date          Wed Jul 15 19:22:42 EDT 2015
Bootloader             L1TC000118D0

N5 2.2: (Pass)
Build ID               20150715002506
Gaia Revision          84d0c76370dcd3d25813b00de55194730884355b
Gaia Date              2015-07-09 13:09:14
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/a5db6d9850f6
Gecko Version          37.0
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150715.040721
Firmware Date          Wed Jul 15 04:07:40 EDT 2015
Bootloader             HHZ12f

N5 master: (Pass)
Build ID               20150715160204
Gaia Revision          b9968cdc4a1dee49848fed6159a59c378cea062d
Gaia Date              2015-07-15 12:13:34
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/49683d4e9ebd
Gecko Version          42.0a1
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150715.191550
Firmware Date          Wed Jul 15 19:16:07 EDT 2015
Bootloader             HHZ12f