Closed
Bug 1175835
Opened 9 years ago
Closed 9 years ago
[Contacts][NGA] Extract 'sendEmailOrPick' from Contacts.js to Contacts_buttons.js
Categories
(Firefox OS Graveyard :: Gaia::Contacts, defect)
Tracking
(b2g-master fixed)
RESOLVED
FIXED
FxOS-S2 (10Jul)
Tracking | Status | |
---|---|---|
b2g-master | --- | fixed |
People
(Reporter: jorgep, Assigned: jorgep)
References
Details
(Whiteboard: [NG Gaia Contacts][patch])
Attachments
(1 file, 1 obsolete file)
To reduce dependencies we are going to move sendEmailOrPick() from Contacts.js to Contacts_buttons.js. This function is only used in this class.
Updated•9 years ago
|
Whiteboard: [NG Gaia Contacts]
Target Milestone: NGA S2 (12Jun) → NGA S3 (26Jun)
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8624085 -
Flags: review?(francisco)
Comment 2•9 years ago
|
||
Comment on attachment 8624085 [details]
30645.html
Hola Jorge!
Can you please rebase the patch, some changes enter and we need to update, but will be pretty simple.
Was also think that perhaps the |sendSMS| functionallity is the same, bust go just to the detail, taking into account that needs to load a file.
Thanks!
Attachment #8624085 -
Flags: review?(francisco)
Assignee | ||
Comment 3•9 years ago
|
||
Hello Francisco, I have rebased the patch and I have researched about Contacts.sendSMS. This function is only used on contact_test.js tests. Should we delete this function and its tests? Thanks!
Flags: needinfo?(francisco)
Comment 4•9 years ago
|
||
As NGA Program Manager suggested, let's replace the NGA-X milestones with FxOS-Sx ones (more generic ones), once Bug 1174794 has already landed
Target Milestone: NGA S3 (26Jun) → FxOS-S1 (26Jun)
Updated•9 years ago
|
Attachment #8624085 -
Flags: review?(francisco)
Attachment #8624085 -
Flags: review?(borja.bugzilla)
Updated•9 years ago
|
Whiteboard: [NG Gaia Contacts] → [NG Gaia Contacts][patch]
Comment 5•9 years ago
|
||
Comment on attachment 8624085 [details] 30645.html Hei Jorge, sorry for the late response. Great, as we moved the sms sending to the shared component, we can get rid of: https://github.com/jpruden92/gaia/blob/bug1175835-contacts/apps/communications/contacts/js/contacts.js#L400-L405 and the test case then. Once that's ready, we are ready to merge :) Thanks!
Flags: needinfo?(francisco)
Attachment #8624085 -
Flags: review?(francisco) → review+
Comment 6•9 years ago
|
||
Comment on attachment 8624085 [details]
30645.html
Great job Jorge! Seems that treeheder has some issue right now because all tests are in red. Could you relaunch it? Ensure treeherder is happy and we are ready to merge!
Attachment #8624085 -
Flags: review?(borja.bugzilla) → review+
Updated•9 years ago
|
Keywords: checkin-needed
Updated•9 years ago
|
Target Milestone: FxOS-S1 (26Jun) → FxOS-S2 (10Jul)
Comment 7•9 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/ba51728daf4de9922f8fbe46645a9d17ac20845d
Updated•9 years ago
|
status-b2g-master:
--- → fixed
Updated•9 years ago
|
Target Milestone: FxOS-S2 (10Jul) → FxOS-S1 (26Jun)
Comment 8•9 years ago
|
||
sorry had to revert this change for test failures like https://treeherder.mozilla.org/logviewer.html#?job_id=2227864&repo=b2g-inbound
Status: RESOLVED → REOPENED
status-b2g-master:
fixed → ---
Flags: needinfo?(jpruden92)
Resolution: FIXED → ---
Target Milestone: FxOS-S1 (26Jun) → ---
Updated•9 years ago
|
Target Milestone: --- → FxOS-S2 (10Jul)
Assignee | ||
Comment 9•9 years ago
|
||
Attachment #8624085 -
Attachment is obsolete: true
Flags: needinfo?(jpruden92)
Attachment #8628158 -
Flags: review?(borja.bugzilla)
Comment 10•9 years ago
|
||
Comment on attachment 8628158 [details]
30769.html
Great job Jorge! Waiting for treeherder to merge. Thanks!
Attachment #8628158 -
Flags: review?(borja.bugzilla) → review+
Updated•9 years ago
|
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
Resolution: --- → FIXED
Updated•9 years ago
|
status-b2g-master:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•