1176597 - Active sidebar tab should be marked with visuallyselected="true"

Status: RESOLVED INVALID

(SeaMonkey :: Sidebar, defect)

Description

[exalm7659]

Attachment: screenshot.gif

bug 1066531 introduced "visuallyselected" attribute for tabs in tabs widget.
It is only useful for Firefox e10s builds, and on normal builds (e.g. in SeaMonkey) it always has the same value as "selected".

Along with that, tab native appearance (-moz-appearance: tab;) now uses the "visuallyselected" attribute to indicate selected tab, while it used "selected" earlier.
That has caused a regression in SM sidebar tabs.

As they still uses the old "selected" attribute, the active tab displays as an inactive one in custom themes that use tab appearance. This is something that cannot be fixed in themes themselves and should be fixed in SM sidebar instead.

It can be reproduced with this style:
.texttab-sidebar {
    -moz-appearance: tab;
}
See the attached screenshots.

The two attributes should probably be updated simultaneously, like in tabs.

Comment 1

[exalm7659]

More info about the change: http://www.hackermusings.com/2015/06/electrolysis-a-tale-of-tab-switching-and-themes/

Comment 2

[exalm7659]

Oh well, seems like themes can do it with wrapping tab content into a box that inherits visuallyselected=selected. I guess this can be closed, since it's kinda of no use for SM itself...