Closed Bug 1176657 Opened 9 years ago Closed 9 years ago

[Contacts][NGA] Remove Contacts.confirmDialog from import_from_vcard.js

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Contacts
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-master fixed)

Status:
RESOLVED FIXED
Milestone:
FxOS-S1 (26Jun)
Tracking Flags:
Tracking Status
b2g-master --- fixed

People

(Reporter: jorgep, Assigned: mancas)

References

Details

(Whiteboard: [NG Gaia Contacts][patch])

Attachments

(1 file)

Contacts.confirmDialog removed
46 bytes, text/x-github-pull-request
borjasalguero
: review+
arcturus
: review+
Details | Review 
confirmDialog() function doesn't exist on Contacts.js class and its functionality was moved to ConfirmDialog class.

We should change Contacts.confirmDialog() by ConfirmDialog.show().

        Attachment #8625249 -
        Flags: review?(francisco)

    
  

        Attachment #8625249 -
        Flags: review?(francisco)

        Attachment #8625249 -
        Flags: review?(borja.bugzilla)

        Attachment #8625249 -
        Flags: review?(borja.bugzilla) → review+
Whiteboard: [NG Gaia Contacts] → [NG Gaia Contacts][patch]

    
    

    
  
Comment on attachment 8625249 [details] [review]
Contacts.confirmDialog removed

Good catch. LGTM.

        Attachment #8625249 -
        Flags: review?(francisco) → review+

    
    

    
  
Relaunched unit tests, once they are gree we are ready to land.

    
  
Blocks: 1177662

    
  
No longer blocks: 1177662

    
    

    
  
https://github.com/mozilla-b2g/gaia/commit/481fba7b10dfdebcec6807170c0257a527c174cf
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: