1176694 - Pressing the "Not Junk" in the new window does not update standalone message window, but updates in the main window.

Status: RESOLVED FIXED

(Thunderbird :: Message Reader UI, defect)

Description

[Ilya]

User Agent: Mozilla/5.0 (Windows NT 6.3; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/42.0.2311.152 YaBrowser/15.6.2311.3927 Safari/537.36

Steps to reproduce:

1. Select a message in the message list.
2. In the context menu, select "Open message in a New Window."
3. Press the "Not Junk."


Actual results:

1. Message reloaded in the main window (three pane window). 
2. Notification of junk has not hidden.


Expected results:

1. Message reloaded in the new window (one pane window). 
2. Notification of junk has hidden.

Comment 1

[Wayne Mery (:wsmwk)]

Did version 31 give different results?

Comment 2

[Ilya]

(In reply to Wayne Mery (:wsmwk, use Needinfo for questions) from comment #1)
> Did version 31 give different results?

In version 31.6.0 result is the same as in version 38. 

My research (maybe it will help):
When user press "not junk" in a new window:
1) Called the function "JunkSelectedMessages(setAsJunk)" from junkCommands.js. 
2) Changing the status of the message is listened in the folderListner ("OnItemEvent: function(folder, event)"). 
3) folderListner calls function "HandleJunkStatusChanged(folder)".
4) "HandleJunkStatusChanged(folder)" calls function "ReloadMessage()".

But folderListner defined in msgMail3PaneWindow.js and only works for main window (3 pane window).

Comment 3

[Wayne Mery (:wsmwk)]

some good diagnosis in comment 2

Comment 4

[:aceman]

Do you click the "Not junk" in the new window? Or in the original message preview in 3-pane window?

If I click it in the new window, the message is actually moved from Junk folder to Inbox AND the new window is closed.

Do you see something else?

Comment 5

[Wayne Mery (:wsmwk)]

Ilya?

(In reply to :aceman from comment #4)
> Do you click the "Not junk" in the new window? Or in the original message
> preview in 3-pane window?
> 
> If I click it in the new window, the message is actually moved from Junk
> folder to Inbox AND the new window is closed.
> 
> Do you see something else?

Comment 6

[Ilya]

38.6 has same behavior

Comment 7

[John Bieling (:TbSync)]

Attachment: Bug 1176694 - Reload message in all windows, when the junk status changes and reload is required. r=mkmelin

Comment 8

[John Bieling (:TbSync)]

try:
https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=5de005157120dae17a5cd07cf6361e1102795788

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/6f1b7165ec11
Reload message in all windows, when the junk status changes and reload is required. r=mkmelin