1177024 - Compiler errors in GTK3 build with clang

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Botond Ballo [:botond]]

I did a GTK3 build of trunk with clang as the compiler, and got some warnings-as-errors. Will post a patch that fixes them.

Comment 1

[Botond Ballo [:botond]]

Attachment: MozReview Request: Bug 1177024 - Fix clang warnings-as-errors in GTK3 build. r=karlt

Bug 1177024 - Fix clang warnings-as-errors in GTK3 build. r=karlt

Comment 2

[Karl Tomlinson (:karlt)]

Comment on attachment 8625650 [details]
MozReview Request: Bug 1177024 - Fix clang warnings-as-errors in GTK3 build. r=karlt

https://reviewboard.mozilla.org/r/11901/#review10433

Ship It!

::: widget/gtk/nsWindow.cpp:1950
(Diff revision 1)
>  #else
>      haveEvent = false;

Please remove this now unnecessary #else block.

Comment 3

[Botond Ballo [:botond]]

Thanks! Addressed comment and landed.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/46b5faf58c7b

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/46b5faf58c7b