1177271 - Add WebGLFormat format tables

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Kelsey Gilbert [:jgilbert]]

Attachment: solo-formats.diff

Let's just get the data in the tree so we can start using it, even if we haven't switched everything over yet.

Comment 1

[Kelsey Gilbert [:jgilbert]]

Attachment: 0002-Get-it-compiling.patch

Comment 2

[u480271]

Comment on attachment 8626700 [details] [diff] [review]
0002-Get-it-compiling.patch

Review of attachment 8626700 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry this took so long.

Comment 3

[u480271]

OK, I pulled the patch locally and it doesn't compile on OS X at all. After fixing uint8_t/uint16_t issue, compilation dies on std::initializer_list. Grepping the code base, it appears to not be used by any gecko code. Could we do this with out the use of std::initializer_list?

Comment 4

[Kelsey Gilbert [:jgilbert]]

(In reply to Dan Glastonbury :djg :kamidphish from comment #3)
> OK, I pulled the patch locally and it doesn't compile on OS X at all. After
> fixing uint8_t/uint16_t issue, compilation dies on std::initializer_list.
> Grepping the code base, it appears to not be used by any gecko code. Could
> we do this with out the use of std::initializer_list?

I was told this might happen.

Comment 5

[Kelsey Gilbert [:jgilbert]]

Attachment: 0003-Make-it-compiler-portable.patch

Comment 6

[u480271]

Have you bounced these patch off of Try?

Comment 7

[Kelsey Gilbert [:jgilbert]]

And we're finally clean:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3700042c6641

Comment 8

[Kelsey Gilbert [:jgilbert]]

Attachment: 0004-more.patch

Comment 9

[u480271]

Comment on attachment 8630754 [details] [diff] [review]
0004-more.patch

Review of attachment 8630754 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/canvas/WebGLFormats.cpp
@@ +475,5 @@
>  }
>  
> +//////////////////////////////////////////////////////////////////////////////////////////
> +//////////////////////////////////////////////////////////////////////////////////////////
> +//////////////////////////////////////////////////////////////////////////////////////////

O_O

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/694521589eb0

Comment 11

[Phil Ringnalda (:philor)]

Excellent, it compiles. I'd recommend adding debug tests to your try push next, to be sure you don't leak a Mutex in mochitests and crashtests and mochitest-dt.

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/97b92a4f10ab

Comment 12

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/97c42d4fbdb1

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/97c42d4fbdb1