Closed Bug 1178157 Opened 9 years ago Closed 9 years ago

[Settings] Define Battery using new syntax provided by Observable

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Settings
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: arthurcc, Assigned: arthurcc)

References

Details

Attachments

(1 file)

link to https://github.com/mozilla-b2g/gaia/pull/30736
182 bytes, text/html
eragonj
: review+
Details 
Define the module using new syntax.
EJ, could you help review this simple patch? Thanks!

In addition to the syntax change, I also included some common modules in main.js so that we no longer need to exclude them in require.js.
Attachment #8627093 - Flags: review?(eragonj+moz)
Comment on attachment 8627093 [details]
link to https://github.com/mozilla-b2g/gaia/pull/30736

Thanks Arthur !! This patch looks nice, r+++.
Attachment #8627093 - Flags: review?(eragonj+moz) → review+
No longer depends on: 1178229
Summary: [Settings][meta] Define Battery using new syntax provided by Observable → [Settings] Define Battery using new syntax provided by Observable
Thanks, EJ!

master: 399ac33c9a44d8988f1429e761063f04ebd3c917
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: