1178811 - Error message concerning expired Bugzilla session is misleading

Status: RESOLVED FIXED

(MozReview Graveyard :: General, defect, P1)

Description

[Mark Côté [:mcote]]

If you try to perform a Bugzilla-related action from within MozReview (search for users, publish a review/review request, etc.) and the Bugzilla login cookie that MozReview stores on your behalf has expired, you will get the following error:

Bugzilla error: The cookies or token provide were not valid or have expired. You may login again to get new cookies or a new token.

This comes straight from Bugzilla.  It is rather confusing because the implication is that you should log out and back into Bugzilla, whereas the real fix is to log out of and back into Review Board (causing a fresh cookie to be stored).

We should catch these particular error messages and rewrite them into something more comprehensible before passing them up to the UI.

Note that this problem will change but may still be relevant after the switch to Bugzilla API keys, since Bugzilla will return an error if the user has revoked their key.  The fix will be the same, but we'll have to look for the new message/code.

Comment 1

[Mark Côté [:mcote]]

Attachment: MozReview Request: mozreview: Use a more comprehensible error message when the Bugzilla cookie has expired (bug 1178811). r?smacleod

mozreview: Use a more comprehensible error message when the Bugzilla cookie has expired (bug 1178811). r?smacleod

Comment 2

[Steven MacLeod [:smacleod]]

Comment on attachment 8630052 [details]
MozReview Request: mozreview: Use a more comprehensible error message when the Bugzilla cookie has expired (bug 1178811). r?smacleod

https://reviewboard.mozilla.org/r/12671/#review11225

::: pylib/rbbz/rbbz/bugzilla.py:23
(Diff revision 1)
> +                # is a little confusing in the context of MozReview.  Override

:O... please don't tell me you're a 2 spaces after period person? 1 space please... 1 space :)

Comment 3

[Mark Côté [:mcote]]

https://reviewboard.mozilla.org/r/12671/#review11225

> :O... please don't tell me you're a 2 spaces after period person? 1 space please... 1 space :)

For monospace fonts, I am.  But I'm not married to it. :)

Comment 4

[Mark Côté [:mcote]]

http://hg.mozilla.org/hgcustom/version-control-tools/rev/d7af1f2c0dd5