117907 - Patch fixing release build of JavaScript debugger (console)

Status: VERIFIED FIXED

(Other Applications Graveyard :: Venkman JS Debugger, defect)

Description

[Jörg Schaible]

jsdb cannot be build with current jsdb.mak. Any call to mk "BUILD_OPT=1" will 
result in an error of the make file. Attachment provided with a unified diff.

Comment 1

[Jörg Schaible]

Sorry file attachment does not work neither with IE6 nor mozilla 0.9.5
Bugzilla claims diff file to be empty every time.

===================== jsdb.diff =====================
--- jsdb.mak    Thu Nov  5 09:57:22 1998
+++ jsdb.new.mak        Thu Jan  3 13:11:50 2002
@@ -62,19 +62,19 @@
 
 $(OBJ)\js32.dll :
     @cd ..\..\src
-    @nmake -f js.mak CFG="js - Win32 Debug"
+    @nmake -f js.mak CFG="js - Win32 $(OBJ)"
     @cd ..\jsd\jsdb
     @echo Copying dll from js/src
     @copy $(JSSRC)\$(OBJ)\js32.dll  $(OBJ)  >NUL
-    @copy $(JSSRC)\$(OBJ)\js32.pdb  $(OBJ)  >NUL
+    @if "$(OBJ)" == "Debug" copy $(JSSRC)\$(OBJ)\js32.pdb  $(OBJ)  >NUL
 
 $(OBJ)\jsd.dll :
     @cd ..
-    @nmake -f jsd.mak JSD_THREADSAFE=1
+    @nmake -f jsd.mak JSD_THREADSAFE=1 BUILD_OPT=$(BUILD_OPT)
     @cd jsdb
     @echo Copying dll from js/jsd
     @copy $(JSD)\$(OBJ)\jsd.dll  $(OBJ)  >NUL
-    @copy $(JSD)\$(OBJ)\jsd.pdb  $(OBJ)  >NUL
+    @if "$(OBJ)" == "Debug" copy $(JSD)\$(OBJ)\jsd.pdb  $(OBJ)  >NUL
 
 dlls : $(OBJ)\js32.dll $(OBJ)\jsd.dll
 
@@ -95,8 +95,8 @@
 
 deep_clean: clean
     @cd ..\..\src
-    @nmake -f js.mak CFG="js - Win32 Debug" clean
+    @nmake -f js.mak CFG="js - Win32 $(OBJ)" clean
     @cd ..\jsd\jsdb
     @cd ..
-    @nmake -f jsd.mak clean
+    @nmake -f jsd.mak clean BUILD_OPT=$(BUILD_OPT)
     @cd jsdb
=====================================================

Comment 2

[Chris Lyon]

*** Bug 117906 has been marked as a duplicate of this bug. ***

Comment 3

[Robert Ginda]

-    @copy $(JSSRC)\$(OBJ)\js32.pdb  $(OBJ)  >NUL
+    @if "$(OBJ)" == "Debug" copy $(JSSRC)\$(OBJ)\js32.pdb  $(OBJ)  >NUL

Why only copy into a OBJ specfic subdirectory for Debug builds?

Comment 4

[Jörg Schaible]

The .pdb files are only generated if the linker's option /debug is set. This is 
only true for debug builds (see BUILD_OPT settings). Since copy fails (and 
therefore the complete build) for the non existing file the copy action is only 
valid building the debug version.

As an alternative you could build the exe's and dll's always with the /debug 
switch of the linker, since it has no influence on the resulting exe or dll 
(all debug info is in the .pdb), but this would result in changes in all 
dependent make files. Advantage: Even for release builds you would have a 
visible call stack as it is available for the system libraries installing the 
debug symbols.

Comment 5

[Robert Ginda]

Oh, I see.  Patch checked in as is, thanks for the diff :)

Comment 6

[Christopher Aillon (sabbatical, not receiving bugmail)]

Verify checked in