117927 - remove unused static variables in editor, netwerk, layout, content

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect)

Description

[Kathleen :Brade]

This bug is to cover removal of unused static variables in mozilla/editor
r=glazou; rs=shaver

Comment 1

[Kathleen :Brade]

272 bytes removed from data today; more to come on another day

Comment 2

[Kathleen :Brade]

darin has given me an rs= for mozilla/netwerk

Comment 3

[Kathleen :Brade]

A quick first pass of netwerk files found 345 bytes of unused static variables
or constants.  They are now checked in.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I'm not sure what you're using to find these, but one easy way to find them is
to look at the warnings given by the IRIX native compiler.  Problem is, the one
on tinderbox (cement on Seamonkey-Ports) is a depend build, so you need to get a
good log after someone causes a full rebuild.  (However, the IRIX compiler won't
warn about ones that aren't declared |static|.)

Comment 5

[Kathleen :Brade]

A quick pass at mozilla/layout found 465 bytes which have now been removed.

dbaron--I am using the link map file on Mac (produced with CodeWarrior).

Comment 6

[Kathleen :Brade]

I have 643 bytes of data that can be removed in mozilla/content...

Comment 7

[Kathleen :Brade]

Attachment: removal of unused static/globals in mozilla/content

Comment 8

[Johnny Stenback (:jst)]

Comment on attachment 64168 [details] [diff] [review]
removal of unused static/globals in mozilla/content

Nice, sr=jst

Comment 9

[Darin Fisher]

Comment on attachment 64168 [details] [diff] [review]
removal of unused static/globals in mozilla/content

r/sr=darin

Comment 10

[Kathleen :Brade]

resolving this bug as fixed; there are more to be removed but they get slightly
trickier (they'll have to wait for another bug)

Comment 11

[sujay]

Kathy, please verify this one...thanks.

Comment 12

[Kathleen :Brade]

v