1179280 - Update ANGLE from chromium/2214 to chromium/2466

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Milan Sreckovic [:milan] (needinfo for best results)]

Make sure we touch README.mozilla so that we can track what version we're on.

Comment 1

[Milan Sreckovic [:milan] (needinfo for best results)]

I don't really want to wait for our patches to get uplifted, but lets see how the timing goes.  If we do have local patches, I'd like the landing of this to be in a three part patch set - the first one to undo our changes and get angle back to what it was in 2214; the second to just update to 2403; the third one to add our changes on top.

Comment 2

[Milan Sreckovic [:milan] (needinfo for best results)]

We should also investigate the flags ANGLE has and see if we're doing the right thing.

Comment 3

[Milan Sreckovic [:milan] (needinfo for best results)]

Stuff in WebGLShaderValidator.cpp, ChooseValidatorCompileOptions function.

Comment 4

[Kelsey Gilbert [:jgilbert]]

(In reply to Milan Sreckovic [:milan] from comment #2)
> We should also investigate the flags ANGLE has and see if we're doing the
> right thing.

I did do this in the past (maybe when I did the WebGLShaderValidator code), and cross-compared what we do with WRT Chromium.

Comment 5

[Jeff Muizelaar [:jrmuizel]]

WIP in https://github.com/jrmuizel/angle/tree/minimal-changes-on-chrome-2466

Comment 6

[Jeff Muizelaar [:jrmuizel]]

Try push:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d9cbb41bacba

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/56db457aef33

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/56db457aef33

Comment 9

[Jukka Jylänki]

There is a performance impact observed after this update, marked down as https://bugzilla.mozilla.org/show_bug.cgi?id=1210683.

Comment 10

[Liz Henry (:lizzard) (relman/hg->git project)]

Marking affected for 43.

Comment 11

[Jeff Muizelaar [:jrmuizel]]

(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #10)
> Marking affected for 43.

That doesn't make sense to me. This didn't land until 44.

Comment 12

[Liz Henry (:lizzard) (relman/hg->git project)]

I'll find you on irc, there was a reference to this from another bug.

Comment 13

[Liz Henry (:lizzard) (relman/hg->git project)]

I misunderstood, thanks for the explanation Jeff!