1179442 - imap maildir folder has false excess unread message count in folder pane

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[Kent James (:rkent)]

One of my folders has an unread count in the folder pane that shows 37 unread messages more than are actually there. I have not been able to get rid of it. The count is correct on restart, but the first time I click on the folder it adds the extra false unread message count.

Comment 1

[Kent James (:rkent)]

Here's why repair folder is failing. In folderpane.js, repair has:

      if (folder.supportsOffline) {
        // Remove the offline store, if any.
        let offlineStore = folder.filePath;
        if (offlineStore.exists())
          offlineStore.remove(false);
      }

which generates JavaScript error: chrome://messenger/content/folderPane.js, line 2443: NS_ERROR_FAILURE: Component returned failure code
: 0x80004005 (NS_ERROR_FAILURE) [nsIFile.remove]

That is, you cannot remove a maildir directory with a simple .remove command because it is a directory and not a file.

Comment 2

[Kent James (:rkent)]

Attachment: Make the offline store delete recursive

Although this can cause main thread lockup while the OS is deleting thousands of files, this is no different than how it is handled in the main maildir C++ code. For a repair operation, I think this is acceptable.

Comment 4

[Magnus Melin [:mkmelin]]

Comment on attachment 8628544 [details] [diff] [review]
Make the offline store delete recursive

Review of attachment 8628544 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, sorry for the delay. r=mkmelin

Comment 5

[Kent James (:rkent)]

Comment on attachment 8628544 [details] [diff] [review]
Make the offline store delete recursive

http://hg.mozilla.org/comm-central/rev/780522954c42

Comment 6

[Kent James (:rkent)]

Comment on attachment 8628544 [details] [diff] [review]
Make the offline store delete recursive

https://hg.mozilla.org/releases/comm-esr38/rev/7b835a634206
https://hg.mozilla.org/releases/comm-beta/rev/166d8e44fb95
https://hg.mozilla.org/releases/comm-aurora/rev/b378d2df070c