Closed
Bug 1179712
Opened 9 years ago
Closed 9 years ago
Create a Pin Card component
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
FxOS-S2 (10Jul)
People
(Reporter: apastor, Assigned: apastor)
References
Details
(Keywords: feature, Whiteboard: [systemsfe])
Attachments
(1 file)
Create a Pin Card component using this visual spec: https://docs.google.com/presentation/d/19BcRbnHqAifE_Cp21KkfxRswNR5s9dfq_HGBH43Bbhs/pub?start=false&loop=false&delayms=3000#slide=id.g98d4de165_2_172
|
Assignee | |
Comment 1•9 years ago
|
||
|
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → apastor
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8628887 -
Flags: review?(bfrancis)
|
||
Updated•9 years ago
|
Target Milestone: --- → FxOS-S2 (10Jul)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8628887 [details] [review] Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/30802 Thanks Alberto, I will try to review this properly later today but can you swap out the default pin icon for the icons Eric provided in bug 1174813? Also, I think we need a peer of the Shared module to review this as well, flagging Kevin.
Attachment #8628887 -
Flags: review?(kgrandon)
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8628887 [details] [review] Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/30802 R+ with nits on github, thanks!
Attachment #8628887 -
Flags: review?(kgrandon) → review+
|
|
||
Comment 4•9 years ago
|
||
Comment on attachment 8628887 [details] [review] Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/30802 thanks
Attachment #8628887 -
Flags: review?(bfrancis) → review+
|
|
Assignee | |
Comment 5•9 years ago
|
||
master: https://github.com/mozilla-b2g/gaia/commit/20e6960417b67d6f54032c62ce462987bb86a819
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•