1180435 - Topic system message is duplicated on joining a room

Status: RESOLVED FIXED

(Chat Core :: XMPP, defect)

Description

[aleth [:aleth]]

23:09:29 - The topic for [e-mail] is: Pidgin, Finch, and libpurple development headquarters.
23:09:29 - rekkanoryo has set the subject to: Pidgin, Finch, and libpurple development headquarters

Could do without one or the other system message.

Comment 1

[Abdelrahman Ahmed [:abdelrahman]]

Attachment: rev 1 - avoid duplicating topic system message

Comment 2

[aleth [:aleth]]

Comment on attachment 8633822 [details] [diff] [review]
rev 1 - avoid duplicating topic system message

Review of attachment 8633822 [details] [diff] [review]:
-----------------------------------------------------------------

::: chat/protocols/xmpp/xmpp.jsm
@@ +1379,5 @@
>        // TODO There can be multiple subject elements with different xml:lang
>        // attributes.
>        muc.setTopic(subject.innerText, nick);
>      }
> +    else if (body) {

You can just return early after setTopic instead, as receiving a subject shouldn't really trigger typing notifications.

Comment 3

[Abdelrahman Ahmed [:abdelrahman]]

Attachment: rev 2 - avoid duplicating topic system message

Comment 4

[Patrick Cloke [:clokep]]

https://hg.mozilla.org/comm-central/rev/3487a322b28d

Comment 5

[Patrick Cloke [:clokep]]

Updating milestone from 1.6 to 42.