1180481 - Remove aero from the tree. Part 3 (messenger)

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Richard Marti (:Paenglab)]

Remove messenger-aero.css

Comment 1

[Richard Marti (:Paenglab)]

Attachment: No-messenger-aero.patch

Remove messenger-aero.css. This patch needs bug 1180475 applied first.

Comment 2

[Richard Marti (:Paenglab)]

Attachment: No-messenger-aero.patch

Found a not correctly indented part.

Comment 3

[Richard Marti (:Paenglab)]

Comment on attachment 8632425 [details] [diff] [review]
No-messenger-aero.patch

Blake has ho possibility to review this patch for a couple of weeks. Changing to Philipp.

Comment 4

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 8632425 [details] [diff] [review]
No-messenger-aero.patch

Review of attachment 8632425 [details] [diff] [review]:
-----------------------------------------------------------------

r=philipp with comments considered:

::: mail/themes/windows/mail/messenger.css
@@ +231,5 @@
> +
> +  #tabmail-buttons > toolbarbutton {
> +    margin-top: 3px;
> +    margin-bottom: 0;
> +  }

There are the same rules in the other block describing winxp. Maybe it makes sense to put these rules into the common block, and then overwrite them on the older windows version instead?

There may also be some other rules like this I missed.

Comment 5

[Richard Marti (:Paenglab)]

Attachment: No-messenger-aero.patch

Updated the commit message to r=Fallen

(In reply to Philipp Kewisch [:Fallen] from comment #4)
> Comment on attachment 8632425 [details] [diff] [review]
> No-messenger-aero.patch
> 
> Review of attachment 8632425 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> r=philipp with comments considered:
> 
> ::: mail/themes/windows/mail/messenger.css
> @@ +231,5 @@
> > +
> > +  #tabmail-buttons > toolbarbutton {
> > +    margin-top: 3px;
> > +    margin-bottom: 0;
> > +  }
> 
> There are the same rules in the other block describing winxp. Maybe it makes
> sense to put these rules into the common block, and then overwrite them on
> the older windows version instead?
> 
> There may also be some other rules like this I missed.

Moved the possible non-XP rules to common and let the XP rules overwrite them.

Comment 6

[aleth [:aleth]]

url:        https://hg.mozilla.org/comm-central/rev/a7e8b30f993a55e84d7776123be7e6b90a254663
changeset:  a7e8b30f993a55e84d7776123be7e6b90a254663
user:       Richard Marti <[e-mail]>
date:       Thu Aug 06 12:36:18 2015 +0200
description:
Bug 1180481 - Get rid of messenger-aero.css. r=philipp