Closed Bug 1180588 Opened 9 years ago Closed 9 years ago

Spinner size is wrong on retina computer (when manually entering details for new account)

Categories

(Thunderbird :: Theme, defect)

Product:
Thunderbird
Component:
Theme
Platform:
Unspecified
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 42.0

People

(Reporter: sole, Assigned: Paenglab)

Details

Attachments

(2 files, 1 obsolete file)

Screenshot 2015-07-06 08.49.35.png
12.94 KB, image/png
Details
retinaSpinner.patch
976 bytes, patch
Paenglab
: review+
Details | Diff | Splinter Review 
See attachment - the spinner is wrongly sized and also not aligned to anything in particular.

It's not P1 but it does look ugly. Maybe a good first bug depending on how complex the layout is? :-)
Component: Account Manager → Theme
OS: Unspecified → Mac OS X
Attached patch retinaSpinner.patch (obsolete) — — Splinter Review 
Blake, sorry to flood you with reviews.

This is a one liner. I have no Retina Mac to test and tested the functionality with other images but it should work.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8630071 - Flags: review?(bwinton)
Comment on attachment 8630071 [details] [diff] [review]
retinaSpinner.patch

I think that line should be in the non-retina version, since we want it to be the same size for both…
But aside from that, r=me.
Attachment #8630071 - Flags: review?(bwinton) → review+
Comment addressed.
Attachment #8630071 - Attachment is obsolete: true
Attachment #8631632 - Flags: review+
Keywords: checkin-needed
url:        https://hg.mozilla.org/comm-central/rev/14bce500986370c97b7a0bf6dd17057ca6ee2c1f
changeset:  14bce500986370c97b7a0bf6dd17057ca6ee2c1f
user:       Richard Marti <richard.marti@gmail.com>
date:       Thu Jul 09 17:43:06 2015 +0200
description:
Bug 1180588 - Fix the spinner size for Retina displays in new account window. r=bwinton
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 42.0
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: