1180964 - Provide a C++ friendly version of LoadInfo on nsIChannel

Status: RESOLVED FIXED

(Core :: DOM: Security, defect)

Comment 1

[Christoph Kerschbaumer [:ckerschb]]

Attachment: bug_1180964_loadinfo_getter.patch

Jonas, what do you think? If you are fine with that change I would ask a necko peer to review. I think it would make C++ a whole lot nicer instead of having to use the outgoing argument for loadInfo on the channel all the time.

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 8630540 [details] [diff] [review]
bug_1180964_loadinfo_getter.patch

Review of attachment 8630540 [details] [diff] [review]:
-----------------------------------------------------------------

::: netwerk/base/nsIChannel.idl
@@ +318,5 @@
> +  inline already_AddRefed<nsILoadInfo> GetLoadInfo()
> +  {
> +    nsCOMPtr<nsILoadInfo> result;
> +    nsresult rv = GetLoadInfo(getter_AddRefs(result));
> +    NS_ENSURE_SUCCESS(rv, nullptr);

Just do MOZ_ASSERT(NS_SUCCEEDED(rv) || !result). Per XPCOM rules that should always pass. That way the release code is simpler.

Comment 3

[Christoph Kerschbaumer [:ckerschb]]

Attachment: bug_1180964_loadinfo_getter.patch

Thanks Jonas. Steve, are you fine with that?

Comment 4

[Steve Workman [:sworkman] (INACTIVE)]

Comment on attachment 8630611 [details] [diff] [review]
bug_1180964_loadinfo_getter.patch

Review of attachment 8630611 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM - Thanks Chris!

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/57055f96a040

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/57055f96a040