1181198 - Refactor all javascript to use 4 spaces for indentation

Status: RESOLVED FIXED

(Webtools Graveyard :: Air Mozilla, defect)

Description

[Peter Bengtsson [:peterbe]]

Our .editorconfig dictates that written javascript should have 4 spaces for indentation. [0]

Some of our files are not following that standard. This makes it hard to edit these files since almost all [sane] editors follow whatever the project .editorconfig file says. 

Some files are vendor libraries downloaded and included from the interwebs. Those we leave alone. The files that use 2 spaces, that need to be refactored are:

base/static/js/gallery_select.js (mixed mess)
manage/static/manage/js/event-tweets.js 

[0] https://github.com/mozilla/airmozilla/blob/e4b4fdbdb14edf1018bcdae608a2dbcf7683ef46/.editorconfig#L5

Comment 1

[tannishk sharma]

Assign me this bug

Comment 2

[Peter Bengtsson [:peterbe]]

(In reply to tannishk sharma from comment #1)
> Assign me this bug

Hi! We usually do that *after* the PR has been received and in under review. For more senior contributors we assign before the work begins.

Comment 3

[Gaurav]

Hi Peter, I have changed all the 2 space indents to 4 space indents in 
base/static/js/gallery_select.js 

while the other file was already 4 space indented here's the PR https://github.com/mozilla/airmozilla/pull/545

Comment 4

[[github robot]]

Commit pushed to master at https://github.com/mozilla/airmozilla

https://github.com/mozilla/airmozilla/commit/bc834d9efa94a28dfff01261b091574e6bf2b198
Merge pull request #545 from deathping1994/master

Changed 2 space indent to 4 space indent - fixes Bug 1181198