1181213 - Stagefright: CHECK_EQ( (unsigned)ptr[0],1u) failed: 65 vs. 1 in MPEG4Extractor.cpp

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P1)

Description

[Tyson Smith [:tsmith]]

Attachment: test_case.mp4

A/MPEG4Extractor(34214): /builds/slave/m-cen-l64-asan-d-ntly-00000000/build/src/media/libstagefright/frameworks/av/media/libstagefright/MPEG4Extractor.cpp:2643 CHECK_EQ( (unsigned)ptr[0],1u) failed: 65 vs. 1

Comment 1

[Chris Peterson [:cpeterson]]

Gerald, here's another Stagefright bug.

Comment 2

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: 1181213-gtest.patch

Added gtest case.

Note: This bug is effectively fixed by bug 1181215, so only this test case is
provided here to prove the successful resolution of this bug.

Comment 3

[Ralph Giles (:rillian)]

Comment on attachment 8683925 [details] [diff] [review]
1181213-gtest.patch

Review of attachment 8683925 [details] [diff] [review]:
-----------------------------------------------------------------

Probably good to meantion mp4 in commit message.

"Bug 1181213 - Added mp4 gtest case - r=rillian"

Comment 4

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: 1181213-gtest.patch

Clarified check-in comment, no actual changes; carrying r+.

Comment 5

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Check-in in this order: bug 1181719, bug 1181223, bug 1181220, bug 1181215, bug 1181213
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=20e7b755a695

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9f4513bf2d03

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9f4513bf2d03

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9f4513bf2d03