Closed
Bug 1181913
Opened 9 years ago
Closed 9 years ago
Data race in AudioSink::mWritten
Categories
(Core :: Audio/Video, defect)
Core
Audio/Video
Tracking
()
RESOLVED
FIXED
mozilla42
Tracking | Status | |
---|---|---|
firefox42 | --- | fixed |
People
(Reporter: jwwang, Assigned: jwwang)
References
Details
Attachments
(1 file)
2.61 KB,
patch
|
kinetik
:
review+
|
Details | Diff | Splinter Review |
1. mWritten is written at [1] on the audio thread without decoder monitor held. 2. mWritten is read at [2] on the state machine thread with decoder monitor held. [1] https://hg.mozilla.org/mozilla-central/file/e7e69cc8c07b/dom/media/AudioSink.cpp#l217 [2] https://hg.mozilla.org/mozilla-central/file/e7e69cc8c07b/dom/media/AudioSink.cpp#l119
Assignee | ||
Comment 1•9 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0ab6968a63bf
Assignee | ||
Comment 2•9 years ago
|
||
Make mWritten an Atomic<int64_t>.
Updated•9 years ago
|
Attachment #8631935 -
Flags: review?(kinetik) → review+
Assignee | ||
Comment 3•9 years ago
|
||
Thanks for the review!
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Comment 5•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/2e5a81baa18b
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox42:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in
before you can comment on or make changes to this bug.
Description
•