1182177 - error cloning mozilla-central with mozext enabled

Status: RESOLVED FIXED

(Developer Services :: Mercurial: mozext, defect)

Description

[[e-mail] (:bhearsum)]

I just tried bundleclone for the first time and got this:
hg clone https://hg.mozilla.org/mozilla-central gecko
downloading bundle https://s3-us-west-2.amazonaws.com/moz-hg-bundles-us-west-2/mozilla-central/f34a7120f46bdfcf9991a0c89a72753f86622df0.gzip.hg
adding changesets
adding manifests
adding file changes
added 251934 changesets with 1421026 changes to 211065 files
finishing applying bundle; pulling
searching for changes
adding changesets
adding manifests
adding file changes
added 163 changesets with 504 changes to 274 files
transaction abort!
rollback completed
** Unknown exception encountered with possibly-broken third-party extension mozext
** which supports versions 3.1 of Mercurial.
** Please disable mozext and try your action again.
** If that fixes the bug please report it to https://bugzilla.mozilla.org/enter_bug.cgi?product=Developer%20Services&component=Mercurial%3A%20mozext
** Python 2.7.9 (default, Apr  2 2015, 15:33:21) [GCC 4.9.2]
** Mercurial Distributed SCM (version 3.1.2)
** Extensions loaded: strip, mq, rebase, share, graphlog, transplant, purge, extdiff, mozext, bundleclone
Traceback (most recent call last):
  File "/usr/bin/hg", line 43, in <module>
    mercurial.dispatch.run()
  File "/usr/lib/python2.7/dist-packages/mercurial/dispatch.py", line 28, in run
    sys.exit((dispatch(request(sys.argv[1:])) or 0) & 255)
  File "/usr/lib/python2.7/dist-packages/mercurial/dispatch.py", line 69, in dispatch
    ret = _runcatch(req)
  File "/usr/lib/python2.7/dist-packages/mercurial/dispatch.py", line 138, in _runcatch
    return _dispatch(req)
  File "/usr/lib/python2.7/dist-packages/mercurial/dispatch.py", line 839, in _dispatch
    cmdpats, cmdoptions)
  File "/usr/lib/python2.7/dist-packages/mercurial/dispatch.py", line 600, in runcommand
    ret = _runcommand(ui, options, cmd, d)
  File "/usr/lib/python2.7/dist-packages/mercurial/dispatch.py", line 930, in _runcommand
    return checkargs()
  File "/usr/lib/python2.7/dist-packages/mercurial/dispatch.py", line 901, in checkargs
    return cmdfunc()
  File "/usr/lib/python2.7/dist-packages/mercurial/dispatch.py", line 836, in <lambda>
    d = lambda: util.checksignature(func)(ui, *args, **cmdoptions)
  File "/usr/lib/python2.7/dist-packages/mercurial/util.py", line 550, in check
    return func(*args, **kwargs)
  File "/usr/lib/python2.7/dist-packages/mercurial/commands.py", line 1331, in clone
    branch=opts.get('branch'))
  File "/usr/lib/python2.7/dist-packages/mercurial/hg.py", line 402, in clone
    destpeer.local().clone(srcpeer, heads=revs, stream=stream)
  File "/home/bhearsum/usr/version-control-tools/hgext/bundleclone/__init__.py", line 504, in clone
    return exchange.pull(self, remote, heads=heads)
  File "/usr/lib/python2.7/dist-packages/mercurial/extensions.py", line 196, in wrap
    return wrapper(origfn, *args, **kwargs)
  File "/home/bhearsum/usr/version-control-tools/hgext/bundleclone/__init__.py", line 336, in pull
    res = orig(repo, remote, *args, **kwargs)
  File "/usr/lib/python2.7/dist-packages/mercurial/extensions.py", line 196, in wrap
    return wrapper(origfn, *args, **kwargs)
  File "/home/bhearsum/usr/version-control-tools/hgext/mozext/__init__.py", line 751, in pull
    res = orig(repo, remote, *args, **kwargs)
  File "/usr/lib/python2.7/dist-packages/mercurial/exchange.py", line 570, in pull
    _pullobsolete(pullop)
  File "/usr/lib/python2.7/dist-packages/mercurial/extensions.py", line 196, in wrap
    return wrapper(origfn, *args, **kwargs)
  File "/home/bhearsum/usr/version-control-tools/hgext/mozext/__init__.py", line 388, in exchangepullpushlog
    if 'pushlog' in pullop.stepsdone or not pullop.remote.capable('pushlog'):
AttributeError: 'pulloperation' object has no attribute 'stepsdone'



This is on Ubuntu with:
hg --version
Mercurial Distributed SCM (version 3.1.2)

Comment 1

[Gregory Szorc [:gps]]

Stack says this is a bug in mozext. Almost certainly a compatibility issue with Mercurial 3.1.

Comment 2

[Gregory Szorc [:gps]]

url:        https://hg.mozilla.org/hgcustom/version-control-tools/rev/3cc77a4359bf8f8fcfe9ab363b6ac7bc131e75a6
changeset:  3cc77a4359bf8f8fcfe9ab363b6ac7bc131e75a6
user:       Gregory Szorc <[e-mail]>
date:       Thu Jul 09 10:46:41 2015 -0700
description:
mozext: restore compatibility with Mercurial 3.1 (bug 1182177)

exchange.pulloperation.stepsdone was added in Mercurial 3.2. Guard the
attribute access.

Comment 3

[Gregory Szorc [:gps]]

Fixed.