Closed
Bug 1182284
Opened 9 years ago
Closed 9 years ago
Fix failure in test_settings_bluetooth.py
Categories
(Firefox OS Graveyard :: Gaia::UI Tests, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: martijn.martijn, Assigned: martijn.martijn)
References
()
Details
Attachments
(1 file)
I was seeing this failure, while testing the pull request in bug 1176527. http://mxr.mozilla.org/gaia/source/tests/python/gaia-ui-tests/gaiatest/tests/functional/settings/test_settings_bluetooth.py Apparently, this has now also switched over to the Bluetooth V2 Api, recently.
|
||
Comment 1•9 years ago
|
||
|
Assignee | |
Comment 2•9 years ago
|
||
Comment on attachment 8631827 [details] [review] [gaia] mwargers:1182284 > mozilla-b2g:master The pull request from bug 1176527 is also visible in this pull request (not sure why), but you can look at: https://github.com/mwargers/gaia/commit/cff593b5d656719eddef55fd77001f44227ce633 I removed the 'bluetooth.visible' setting, because that apparently doesn't happen in the Bluetooth V2 API.
Attachment #8631827 -
Flags: review?(npark)
Attachment #8631827 -
Flags: review?(jlorenzo)
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8631827 [details] [review] [gaia] mwargers:1182284 > mozilla-b2g:master based on what I learned so far about bluetooth since yesterday, it seems okay to me in terms of python code itself.
Attachment #8631827 -
Flags: review?(npark) → review+
|
||
Comment 4•9 years ago
|
||
Comment on attachment 8631827 [details] [review] [gaia] mwargers:1182284 > mozilla-b2g:master LGTM
Attachment #8631827 -
Flags: review?(jlorenzo) → review+
|
|
Assignee | |
Comment 5•9 years ago
|
||
Merged: https://github.com/mozilla-b2g/gaia/commit/c4c2164c99310fe12ffcf801f304adfee806162c
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•