Closed
Bug 1182370
Opened 9 years ago
Closed 9 years ago
_BitScanReverse does not modify `*pIndex` if input is zero
Categories
(Core :: MFBT, defect)
Core
MFBT
Tracking
()
RESOLVED
FIXED
mozilla42
| Tracking | Status | |
|---|---|---|
| firefox42 | --- | fixed |
People
(Reporter: jgilbert, Assigned: jgilbert)
Details
Attachments
(1 file)
|
1.72 KB,
patch
|
Waldo
:
review+
|
Details | Diff | Splinter Review |
MSVC code analysis complains about this. https://msdn.microsoft.com/en-us/library/fbxyd7zd.aspx _BitScanReverse doesn't modify `*pIndex` is the input is all zeros. We need to either test for this before-hand, or test the retval from _BitScanReverse, which is zero if input is zero. (non-zero otherwise)
Attachment #8631949 -
Flags: review?(jwalden+bmo)
|
||
Updated•9 years ago
|
Attachment #8631949 -
Flags: review?(jwalden+bmo) → review+
https://hg.mozilla.org/mozilla-central/rev/5b4a4d8e5a80
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox42:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in
before you can comment on or make changes to this bug.
Description
•