1182620 - Cannot build: sqlcipher/sqlite3.c missing

Status: RESOLVED FIXED

(Firefox for iOS :: Build & Test, defect)

Description

[Boris Dušek]

Building latest code (ddea35aeb120e9b3649f92fdeedaf27bba7a3251) results in build error:

clang: error: no such file or directory: '/path/to/firefox-ios/ThirdParty/sqlcipher/sqlite3.c'

I tried even again doing Steps 1.-6. from "Building the code" in README.md from scratch, but got the same error.

Comment 1

[Boris Dušek]

Please note that this happened after (among other things) I did "git clean -xffd" in my checkout that I checked out months ago (and then only updated using git pull and ./checkout.sh) - maybe some stuff that was earlier present got removed but no-one would not notice unless doing a new checkout (or git clean -xffd)?

Comment 2

[Boris Dušek]

Managed to overcome it by running manually commands from the amalgamation target of sqlcipher:

./configure --enable-tempstore=yes --with-crypto-lib=commoncrypto CFLAGS="-DSQLITE_HAS_CODEC -DSQLITE_TEMP_STORE=2"
make sqlite3.c

But now hitting another error:

/path/to/Library/Developer/Xcode/DerivedData/Client-ddsfbzjydxjurcfycsxnaekdjddj/Build/Intermediates/Client.build/Debug-iphoneos/Storage.build/module.modulemap:2:12: error: header 'Storage-Swift.h' not found
    header "Storage-Swift.h"
           ^
/path/to/firefox-ios/Sync/TabsPayload.swift:7:8: error: could not build Objective-C module 'Storage'
import Storage
       ^

Comment 3

[Boris Dušek]

(In reply to Boris Dušek from comment #2)
> Managed to overcome it by running manually commands from the amalgamation
> target of sqlcipher:
> 
> ./configure --enable-tempstore=yes --with-crypto-lib=commoncrypto
> CFLAGS="-DSQLITE_HAS_CODEC -DSQLITE_TEMP_STORE=2"
> make sqlite3.c
> 
> But now hitting another error:
> 
> /path/to/Library/Developer/Xcode/DerivedData/Client-
> ddsfbzjydxjurcfycsxnaekdjddj/Build/Intermediates/Client.build/Debug-iphoneos/
> Storage.build/module.modulemap:2:12: error: header 'Storage-Swift.h' not
> found
>     header "Storage-Swift.h"
>            ^
> /path/to/firefox-ios/Sync/TabsPayload.swift:7:8: error: could not build
> Objective-C module 'Storage'
> import Storage
>        ^

This was actually with an earlier commit (I tried that to see if the original error would still be reproducible - it was), when updating to ddea35aeb120e9b3649f92fdeedaf27bba7a3251, I am no longer getting the quoted error.

Comment 4

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Is this still happening? I don't see build errors on the CI server.

Did a Clean Build Folder help? (option-shift-command-k)

Comment 5

[Boris Dušek]

(In reply to Stefan Arentz [:st3fan] from comment #4)
> Is this still happening? I don't see build errors on the CI server.

For some reason, this is no longer happening (I did update to latest code, not sure if that did it).

Comment 6

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Marking this as tracking. :sleroux and i just spent like 30 minutes to get this working for a production build to get past this.

We ended up running the amalgamation script manually like :dusek did. After that the build worked.

I think we may want to run the amalgamation manually once and then simply add the generated sqlite3*.[ch] files to the project and never run that build phase again.

Or even include a precompiled .a in the project?

Comment 7

[Boris Dušek]

Not being an Xcode expert, but looking at the amalgamation target's Run script build phase - is it correct that is has sqlite3.c as its input and libsqlcipher.a as its output, when in fact sqlite3.c seems to me like an *output* (not input) of the step? (i.e. make sqlite3.c I suppose generates sqlite3.c).

So maybe just the build phase' inputs and outputs are not correctly specified?

Comment 8

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Attachment: PR: https://github.com/mozilla/firefox-ios/pull/763

This simplifies the sqlcipher target by removing all unused files, adding the generated sqlite3.c, sqlite3.h and sqlite3ext.h files to the project and removing the amalgamation step from the project.

Comment 9

[Stephan Leroux [:sleroux]]

Comment on attachment 8635286 [details] [review]
PR: https://github.com/mozilla/firefox-ios/pull/763

Fresh clone -> checkout -> archive works for me!

Comment 10

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Added some documentation about updating sqlcipher in the project's BUILDING.md

Comment 11

[Boris Dušek]

Comment on attachment 8635286 [details] [review]
PR: https://github.com/mozilla/firefox-ios/pull/763

Works for me on clean checkout.