1182876 - Use the built-in entries for test-track-simple and test-trackwhite-simple in mochitests

Status: REOPENED

(Toolkit :: Safe Browsing, defect, P3)

Description

[François Marier [:francois]]

We currently have test-phish-simple and the likes for Safe Browsing unit tests. We need the same thing for tracking protection.

Comment 1

[François Marier [:francois]]

I have suggested that some test files be served from the same domain as the shavar server: https://github.com/mozilla-services/shavar/issues/43

Comment 2

[François Marier [:francois]]

I've just registered two domains that I will be adding to the test list:

- itisatracker.org
- itisatracker.com

Comment 3

[François Marier [:francois]]

Attachment: MozReview Request: Bug 1182876 - Add test-track-simple list for testing TP. r?dcamp

Bug 1182876 - Add test-track-simple list for testing TP. r?dcamp

Comment 4

[François Marier [:francois]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=272c752f1887

Comment 5

[François Marier [:francois]]

Comment on attachment 8635496 [details]
MozReview Request: Bug 1182876 - Add test-track-simple list for testing TP. r?dcamp

Bug 1182876 - Add test-track-simple list for testing TP. r?dcamp

Comment 6

[François Marier [:francois]]

Comment on attachment 8635496 [details]
MozReview Request: Bug 1182876 - Add test-track-simple list for testing TP. r?dcamp

The URLs themselves were added in bug 1185549.

I will simplify the mochitests so that they use the built-in URLs and don't require toolkit/components/url-classifier/tests/UrlClassifierTestUtils.jsm anymore.

Comment 7

[François Marier [:francois]]

The test-trackwhite-simple table will be added in bug 1141352.

Comment 8

[François Marier [:francois]]

Attachment: WIP patch

Comment 9

[François Marier [:francois]]

Attachment: WIP patch (UI tests)

Comment 10

[Joel Maher ( :jmaher ) (UTC -8)]

:francois, can you work on getting these fixes in place so we can see bug 1214437 fixed or reduced?

Comment 11

[François Marier [:francois]]

(In reply to Joel Maher ( :jmaher) from comment #10)
> :francois, can you work on getting these fixes in place so we can see bug
> 1214437 fixed or reduced?

How important would you say it is? I probably won't have time to look at it for several weeks but I can try to find someone else if you think it should be prioritized higher than a P3.

Comment 12

[Joel Maher ( :jmaher ) (UTC -8)]

This showed up as a potential fix for a high frequency intermittent last week.  Overall, the frequency of that specific failure went down quite a bit- So I would like to see this in, but I don't think we should prioritize it above other work.  If we can have this landed next month, that would be ideal.  If bug 1214437 picks up in frequency again, I will check back in here.

Comment 13

[Joel Maher ( :jmaher ) (UTC -8)]

the failure rate of these tests have been greatly reduced, not sure if it is coincidence or a fix!

Comment 14

[BMO Automation]

Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.